Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps and ESM fix #34

Merged
merged 4 commits into from
Oct 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .eslintrc.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
extends:
- cheminfo-typescript
- cheminfo-react
- plugin:storybook/recommended
rules:
react/jsx-no-bind: off
consistent-return: off
env:
jest: true
2 changes: 2 additions & 0 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,5 @@ jobs:
nodejs:
# Documentation: https://github.com/zakodium/workflows#nodejs-ci
uses: zakodium/workflows/.github/workflows/nodejs.yml@nodejs-v1
with:
lint-check-types: true
29 changes: 0 additions & 29 deletions .github/workflows/storybook.yml

This file was deleted.

12 changes: 9 additions & 3 deletions .storybook/main.js → .storybook/main.mjs
Original file line number Diff line number Diff line change
@@ -1,15 +1,21 @@
module.exports = {
stories: ['../stories/**/*.stories.js'],
export default {
stories: ['../stories/**/*.stories.tsx'],

addons: [
'@storybook/addon-storysource',
'@storybook/addon-links',
'@storybook/addon-essentials',
],

framework: {
name: '@storybook/react-webpack5',
name: '@storybook/react-vite',
options: {
fastRefresh: true,
strictMode: true,
},
},

typescript: {
reactDocgen: 'react-docgen-typescript',
},
};
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ This library is available in three versions, like openchemlib: `react-ocl/minima

## Documentation

See https://zakodium-oss.github.io/react-ocl/ for detailed usage examples.
See https://react-ocl.pages.dev for detailed usage examples.

[npm-image]: https://img.shields.io/npm/v/react-ocl.svg
[npm-url]: https://npmjs.org/package/react-ocl
Expand Down
10 changes: 0 additions & 10 deletions babel.config.js

This file was deleted.

14 changes: 14 additions & 0 deletions base.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
'use strict';

const BaseIdcodeSvgRenderer =
require('./lib-cjs/components/IdcodeSvgRenderer.js').default;
const BaseMolfileSvgRenderer =
require('./lib-cjs/components/MolfileSvgRenderer.js').default;
const BaseSmilesSvgRenderer =
require('./lib-cjs/components/SmilesSvgRenderer.js').default;

module.exports = {
SmilesSvgRenderer: BaseSmilesSvgRenderer,
MolfileSvgRenderer: BaseMolfileSvgRenderer,
IdcodeSvgRenderer: BaseIdcodeSvgRenderer,
};
36 changes: 12 additions & 24 deletions base.d.ts
Original file line number Diff line number Diff line change
@@ -1,24 +1,12 @@
import {
IIdcodeSvgRendererProps as IdcodeProps,
IMolfileSvgRendererProps as MolfileProps,
ISmilesSvgRendererProps as SmilesProps,
} from './types';

export interface IIdcodeSvgRendererProps extends IdcodeProps {
OCL: any;
}
export function IdcodeSvgRenderer(
props: IIdcodeSvgRendererProps,
): JSX.Element;

export interface IMolfileSvgRendererProps extends MolfileProps {
OCL: any;
}
export function MolfileSvgRenderer(
props: IMolfileSvgRendererProps,
): JSX.Element;

export interface ISmilesSvgRendererProps extends SmilesProps {
OCL: any;
}
export function SmilesSvgRenderer(props: ISmilesSvgRendererProps): JSX.Element;
export {
type BaseIdcodeSvgRendererProps,
default as BaseIdcodeSvgRenderer,
} from './lib/components/IdcodeSvgRenderer.d.ts';
export {
type BaseMolfileSvgRendererProps,
default as BaseMolfileSvgRenderer,
} from './lib/components/MolfileSvgRenderer.d.ts';
export {
type BaseSmilesSvgRendererProps,
default as BaseSmilesSvgRenderer,
} from './lib/components/SmilesSvgRenderer.d.ts';
12 changes: 0 additions & 12 deletions base.js

This file was deleted.

6 changes: 3 additions & 3 deletions base.mjs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import BaseIdcodeSvgRenderer from './lib/components/IdcodeSvgRenderer';
import BaseMolfileSvgRenderer from './lib/components/MolfileSvgRenderer';
import BaseSmilesSvgRenderer from './lib/components/SmilesSvgRenderer';
import BaseIdcodeSvgRenderer from './lib/components/IdcodeSvgRenderer.js';
import BaseMolfileSvgRenderer from './lib/components/MolfileSvgRenderer.js';
import BaseSmilesSvgRenderer from './lib/components/SmilesSvgRenderer.js';

export {
BaseSmilesSvgRenderer as SmilesSvgRenderer,
Expand Down
14 changes: 8 additions & 6 deletions core.js → core.cjs
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
'use strict';

const OCL = require('openchemlib/core');
const React = require('react');

const BaseIdcodeSvgRenderer = require('./lib-cjs/components/IdcodeSvgRenderer')
.default;
const BaseMolfileSvgRenderer = require('./lib-cjs/components/MolfileSvgRenderer')
.default;
const BaseSmilesSvgRenderer = require('./lib-cjs/components/SmilesSvgRenderer')
.default;
const BaseIdcodeSvgRenderer =
require('./lib-cjs/components/IdcodeSvgRenderer.js').default;
const BaseMolfileSvgRenderer =
require('./lib-cjs/components/MolfileSvgRenderer.js').default;
const BaseSmilesSvgRenderer =
require('./lib-cjs/components/SmilesSvgRenderer.js').default;

function SmilesSvgRenderer(props) {
return React.createElement(BaseSmilesSvgRenderer, { OCL, ...props });
Expand Down
2 changes: 1 addition & 1 deletion core.d.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export * from './minimal';
export * from './minimal.d.ts';
6 changes: 3 additions & 3 deletions core.mjs
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import OCL from 'openchemlib/core';
import React from 'react';

import BaseIdcodeSvgRenderer from './lib/components/IdcodeSvgRenderer';
import BaseMolfileSvgRenderer from './lib/components/MolfileSvgRenderer';
import BaseSmilesSvgRenderer from './lib/components/SmilesSvgRenderer';
import BaseIdcodeSvgRenderer from './lib/components/IdcodeSvgRenderer.js';
import BaseMolfileSvgRenderer from './lib/components/MolfileSvgRenderer.js';
import BaseSmilesSvgRenderer from './lib/components/SmilesSvgRenderer.js';

export function SmilesSvgRenderer(props) {
return React.createElement(BaseSmilesSvgRenderer, { OCL, ...props });
Expand Down
18 changes: 10 additions & 8 deletions full.js → full.cjs
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
'use strict';

const OCL = require('openchemlib/full');
const React = require('react');

const BaseIdcodeSvgRenderer = require('./lib-cjs/components/IdcodeSvgRenderer')
.default;
const BaseMolfileSvgRenderer = require('./lib-cjs/components/MolfileSvgRenderer')
.default;
const BaseSmilesSvgRenderer = require('./lib-cjs/components/SmilesSvgRenderer')
.default;
const BaseStructureEditor = require('./lib-cjs/components/StructureEditor')
.default;
const BaseIdcodeSvgRenderer =
require('./lib-cjs/components/IdcodeSvgRenderer.js').default;
const BaseMolfileSvgRenderer =
require('./lib-cjs/components/MolfileSvgRenderer.js').default;
const BaseSmilesSvgRenderer =
require('./lib-cjs/components/SmilesSvgRenderer.js').default;
const BaseStructureEditor =
require('./lib-cjs/components/StructureEditor.js').default;

function SmilesSvgRenderer(props) {
return React.createElement(BaseSmilesSvgRenderer, { OCL, ...props });
Expand Down
5 changes: 4 additions & 1 deletion full.d.ts
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
export * from './core';
export { IStructureEditorProps, StructureEditor } from './types';
export {
type StructureEditorProps,
default as StructureEditor,
} from './src/components/StructureEditor';
8 changes: 4 additions & 4 deletions full.mjs
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import OCL from 'openchemlib/full';
import React from 'react';

import BaseIdcodeSvgRenderer from './lib/components/IdcodeSvgRenderer';
import BaseMolfileSvgRenderer from './lib/components/MolfileSvgRenderer';
import BaseSmilesSvgRenderer from './lib/components/SmilesSvgRenderer';
import BaseIdcodeSvgRenderer from './lib/components/IdcodeSvgRenderer.js';
import BaseMolfileSvgRenderer from './lib/components/MolfileSvgRenderer.js';
import BaseSmilesSvgRenderer from './lib/components/SmilesSvgRenderer.js';

export { default as StructureEditor } from './lib/components/StructureEditor';
export { default as StructureEditor } from './lib/components/StructureEditor.js';

export function SmilesSvgRenderer(props) {
return React.createElement(BaseSmilesSvgRenderer, { OCL, ...props });
Expand Down
3 changes: 3 additions & 0 deletions minimal.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
'use strict';

module.exports = require('./lib-cjs/index.js');
10 changes: 5 additions & 5 deletions minimal.d.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
export {
IBaseSvgRendererProps,
IIdcodeSvgRendererProps,
IMolfileSvgRendererProps,
ISmilesSvgRendererProps,
type BaseSvgRendererProps,
type IdcodeSvgRendererProps,
IdcodeSvgRenderer,
type MolfileSvgRendererProps,
MolfileSvgRenderer,
type SmilesSvgRendererProps,
SmilesSvgRenderer,
} from './types';
} from './lib/index.d.ts';
1 change: 0 additions & 1 deletion minimal.js

This file was deleted.

2 changes: 1 addition & 1 deletion minimal.mjs
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export * from './lib/index';
export * from './lib/index.js';
Loading