Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ContextMenu and Dropdown components #585

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

wadjih-bencheikh18
Copy link
Contributor

closes #570
closes #572

@wadjih-bencheikh18 wadjih-bencheikh18 linked an issue Nov 25, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (707c929) 46.80% compared to head (232def0) 47.07%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #585      +/-   ##
==========================================
+ Coverage   46.80%   47.07%   +0.26%     
==========================================
  Files         149      145       -4     
  Lines        7950     7565     -385     
  Branches      146      146              
==========================================
- Hits         3721     3561     -160     
+ Misses       4229     4004     -225     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@targos targos requested a review from stropitek November 26, 2023 09:53
Copy link
Contributor

@stropitek stropitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you separate the stories into more distinct categories:

  • Menus
  • Dropdown menu
  • Context menu

stories/components/dropdown.stories.tsx Outdated Show resolved Hide resolved
Copy link

cloudflare-workers-and-pages bot commented Dec 3, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 232def0
Status: ✅  Deploy successful!
Preview URL: https://bdadb668.react-science.pages.dev
Branch Preview URL: https://572-remove-dropdown-componen.react-science.pages.dev

View logs

@stropitek stropitek merged commit 03d9ce9 into main Dec 4, 2023
12 checks passed
@stropitek stropitek deleted the 572-remove-dropdown-component branch December 4, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Dropdown component Remove ContextMenu
3 participants