Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add editable table text #846

Merged
merged 20 commits into from
Jan 21, 2025
Merged

docs: add editable table text #846

merged 20 commits into from
Jan 21, 2025

Conversation

Sebastien-Ahkrin
Copy link
Contributor

No description provided.

@tpoisseau
Copy link

I thought the idea was to have a component, able to switch between 2 mode (read -> write).
Not provide specifically a table with editable cell.

@Sebastien-Ahkrin
feat: create switchable input
1ec8f42 
can switch between value or input. based on `input` or `value` props. the switch is auto when you click on the value.
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 26, 2024 •
edited
Loading

Deploying react-science with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3b8c7cc
Status: ✅  Deploy successful!
Preview URL: https://664fa874.react-science.pages.dev
Branch Preview URL: https://feat-editable-table.react-science.pages.dev

View logs

@Sebastien-Ahkrin Sebastien-Ahkrin mentioned this pull request Jan 14, 2025
Open
@Sebastien-Ahkrin Sebastien-Ahkrin marked this pull request as ready for review January 14, 2025 12:28
@Sebastien-Ahkrin Sebastien-Ahkrin marked this pull request as draft January 15, 2025 10:21
@Sebastien-Ahkrin Sebastien-Ahkrin marked this pull request as ready for review January 16, 2025 13:40
tpoisseau
tpoisseau approved these changes Jan 16, 2025
View reviewed changes
Copy link

@tpoisseau tpoisseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM but it could be great ENTER do the same than TAB or clicking outside the input.

@Sebastien-Ahkrin Sebastien-Ahkrin marked this pull request as draft January 20, 2025 08:58
@Sebastien-Ahkrin Sebastien-Ahkrin marked this pull request as ready for review January 20, 2025 13:36
stropitek
stropitek reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@stropitek stropitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2025-01-21 at 10 16 07@2x

I removed the outline from the input (creates a double border)

src/components/inline_editable_renderer/inline_editable_renderer.tsx Outdated Show resolved Hide resolved
@Sebastien-Ahkrin Sebastien-Ahkrin merged commit 4848f70 into main Jan 21, 2025
13 checks passed
@Sebastien-Ahkrin Sebastien-Ahkrin deleted the feat-editable-table branch January 21, 2025 14:24
@zakodium-bot zakodium-bot mentioned this pull request Jan 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpoisseau tpoisseau tpoisseau approved these changes

@stropitek stropitek stropitek approved these changes

@targos targos Awaiting requested review from targos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sebastien-Ahkrin @tpoisseau @stropitek