Skip to content

Commit

Permalink
Fix #363
Browse files Browse the repository at this point in the history
  • Loading branch information
@zapadi
zapadi committed Jan 9, 2025
1 parent ac206ee commit 48d9174
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/redmine-net-api/RedmineManagerOptionsBuilder.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,10 @@ internal static Uri CreateRedmineUri(string host, string scheme = null)
uriBuilder.Scheme = uri.Scheme;
uriBuilder.Port = int.TryParse(uri.LocalPath, out var port) ? port : uri.Port;
uriBuilder.Host = uri.Host;
if (!uri.LocalPath.IsNullOrWhiteSpace() && !uri.LocalPath.Contains("."))

Check warning on line 364 in src/redmine-net-api/RedmineManagerOptionsBuilder.cs

View workflow job for this annotation

GitHub Actions / Build ubuntu-latest - dotnet 

Use 'string.Contains(char)' instead of 'string.Contains(string)' when searching for a single character (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1847)

Check warning on line 364 in src/redmine-net-api/RedmineManagerOptionsBuilder.cs

View workflow job for this annotation

GitHub Actions / Build ubuntu-latest - dotnet 

'string.Contains(string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'Redmine.Net.Api.RedmineManagerOptionsBuilder.CreateRedmineUri(string, string)' with a call to 'string.Contains(string, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)

Check warning on line 364 in src/redmine-net-api/RedmineManagerOptionsBuilder.cs

View workflow job for this annotation

GitHub Actions / Build ubuntu-latest - dotnet 

Use 'string.Contains(char)' instead of 'string.Contains(string)' when searching for a single character (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1847)

Check warning on line 364 in src/redmine-net-api/RedmineManagerOptionsBuilder.cs

View workflow job for this annotation

GitHub Actions / Build ubuntu-latest - dotnet 

'string.Contains(string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'Redmine.Net.Api.RedmineManagerOptionsBuilder.CreateRedmineUri(string, string)' with a call to 'string.Contains(string, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)

Check warning on line 364 in src/redmine-net-api/RedmineManagerOptionsBuilder.cs

View workflow job for this annotation

GitHub Actions / Build ubuntu-latest - dotnet 

Use 'string.Contains(char)' instead of 'string.Contains(string)' when searching for a single character (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1847)

Check warning on line 364 in src/redmine-net-api/RedmineManagerOptionsBuilder.cs

View workflow job for this annotation

GitHub Actions / Build ubuntu-latest - dotnet 

'string.Contains(string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'Redmine.Net.Api.RedmineManagerOptionsBuilder.CreateRedmineUri(string, string)' with a call to 'string.Contains(string, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)

Check warning on line 364 in src/redmine-net-api/RedmineManagerOptionsBuilder.cs

View workflow job for this annotation

GitHub Actions / Build ubuntu-latest - dotnet 

Use 'string.Contains(char)' instead of 'string.Contains(string)' when searching for a single character (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1847)

Check warning on line 364 in src/redmine-net-api/RedmineManagerOptionsBuilder.cs

View workflow job for this annotation

GitHub Actions / Build ubuntu-latest - dotnet 

'string.Contains(string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'Redmine.Net.Api.RedmineManagerOptionsBuilder.CreateRedmineUri(string, string)' with a call to 'string.Contains(string, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)

Check warning on line 364 in src/redmine-net-api/RedmineManagerOptionsBuilder.cs

View workflow job for this annotation

GitHub Actions / Build ubuntu-latest - dotnet 

Use 'string.Contains(char)' instead of 'string.Contains(string)' when searching for a single character (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1847)

Check warning on line 364 in src/redmine-net-api/RedmineManagerOptionsBuilder.cs

View workflow job for this annotation

GitHub Actions / Build ubuntu-latest - dotnet 

'string.Contains(string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'Redmine.Net.Api.RedmineManagerOptionsBuilder.CreateRedmineUri(string, string)' with a call to 'string.Contains(string, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)

Check warning on line 364 in src/redmine-net-api/RedmineManagerOptionsBuilder.cs

View workflow job for this annotation

GitHub Actions / Build windows-latest - dotnet 

Use 'string.Contains(char)' instead of 'string.Contains(string)' when searching for a single character (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1847)

Check warning on line 364 in src/redmine-net-api/RedmineManagerOptionsBuilder.cs

View workflow job for this annotation

GitHub Actions / Build windows-latest - dotnet 

'string.Contains(string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'Redmine.Net.Api.RedmineManagerOptionsBuilder.CreateRedmineUri(string, string)' with a call to 'string.Contains(string, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)

Check warning on line 364 in src/redmine-net-api/RedmineManagerOptionsBuilder.cs

View workflow job for this annotation

GitHub Actions / Build windows-latest - dotnet 

Use 'string.Contains(char)' instead of 'string.Contains(string)' when searching for a single character (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1847)

Check warning on line 364 in src/redmine-net-api/RedmineManagerOptionsBuilder.cs

View workflow job for this annotation

GitHub Actions / Build windows-latest - dotnet 

'string.Contains(string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'Redmine.Net.Api.RedmineManagerOptionsBuilder.CreateRedmineUri(string, string)' with a call to 'string.Contains(string, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)

Check warning on line 364 in src/redmine-net-api/RedmineManagerOptionsBuilder.cs

View workflow job for this annotation

GitHub Actions / Build macos-latest - dotnet 

Use 'string.Contains(char)' instead of 'string.Contains(string)' when searching for a single character (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1847)

Check warning on line 364 in src/redmine-net-api/RedmineManagerOptionsBuilder.cs

View workflow job for this annotation

GitHub Actions / Build macos-latest - dotnet 

'string.Contains(string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'Redmine.Net.Api.RedmineManagerOptionsBuilder.CreateRedmineUri(string, string)' with a call to 'string.Contains(string, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)

Check warning on line 364 in src/redmine-net-api/RedmineManagerOptionsBuilder.cs

View workflow job for this annotation

GitHub Actions / Build macos-latest - dotnet 

Use 'string.Contains(char)' instead of 'string.Contains(string)' when searching for a single character (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1847)

Check warning on line 364 in src/redmine-net-api/RedmineManagerOptionsBuilder.cs

View workflow job for this annotation

GitHub Actions / Build macos-latest - dotnet 

'string.Contains(string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'Redmine.Net.Api.RedmineManagerOptionsBuilder.CreateRedmineUri(string, string)' with a call to 'string.Contains(string, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)

Check warning on line 364 in src/redmine-net-api/RedmineManagerOptionsBuilder.cs

View workflow job for this annotation

GitHub Actions / Build macos-latest - dotnet 

Use 'string.Contains(char)' instead of 'string.Contains(string)' when searching for a single character (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1847)

Check warning on line 364 in src/redmine-net-api/RedmineManagerOptionsBuilder.cs

View workflow job for this annotation

GitHub Actions / Build macos-latest - dotnet 

'string.Contains(string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'Redmine.Net.Api.RedmineManagerOptionsBuilder.CreateRedmineUri(string, string)' with a call to 'string.Contains(string, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)

Check warning on line 364 in src/redmine-net-api/RedmineManagerOptionsBuilder.cs

View workflow job for this annotation

GitHub Actions / Build macos-latest - dotnet 

Use 'string.Contains(char)' instead of 'string.Contains(string)' when searching for a single character (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1847)

Check warning on line 364 in src/redmine-net-api/RedmineManagerOptionsBuilder.cs

View workflow job for this annotation

GitHub Actions / Build macos-latest - dotnet 

'string.Contains(string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'Redmine.Net.Api.RedmineManagerOptionsBuilder.CreateRedmineUri(string, string)' with a call to 'string.Contains(string, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)

Check warning on line 364 in src/redmine-net-api/RedmineManagerOptionsBuilder.cs

View workflow job for this annotation

GitHub Actions / Build macos-latest - dotnet 

Use 'string.Contains(char)' instead of 'string.Contains(string)' when searching for a single character (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1847)

Check warning on line 364 in src/redmine-net-api/RedmineManagerOptionsBuilder.cs

View workflow job for this annotation

GitHub Actions / Build macos-latest - dotnet 

'string.Contains(string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'Redmine.Net.Api.RedmineManagerOptionsBuilder.CreateRedmineUri(string, string)' with a call to 'string.Contains(string, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
{
uriBuilder.Path = uri.LocalPath;
}
}
}

Expand Down

0 comments on commit 48d9174

Please sign in to comment.