Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid error when building package importing skeleton with remote components #3470

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

AustinAbro321
Copy link
Contributor

Description

During the create refactor the logic was changed to error when pulling a component from a skeleton package without an associated layer in the oci manifests. This leads to errors when a component is imported that only has remote resources. A tarball isn't created for that component in the skeleton package, and therefore a layer is not created for that component. This changes the logic to follow how it was originally in importchain.fetchOCISkeleton

Related Issue

Fixes #3469

Checklist before merging

@AustinAbro321 AustinAbro321 requested review from a team as code owners February 5, 2025 14:51
Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 9b6b1a7
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/67a37bf9d3c7ee00082eedcb

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 3.03030% with 32 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager2/layout/import.go 3.03% 32 Missing ⚠️
Files with missing lines Coverage Δ
src/internal/packager2/layout/import.go 38.01% <3.03%> (-1.15%) ⬇️

Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321 AustinAbro321 changed the title fix: avoid errors when building skeleton packages with remote components fix: avoid error when building package importing skeleton with remote components Feb 5, 2025
Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AustinAbro321 AustinAbro321 added this to the v0.49.0 milestone Feb 6, 2025
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit 692a8ef Feb 6, 2025
26 checks passed
@AustinAbro321 AustinAbro321 deleted the empty-oci-component-errors branch February 6, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote skeleton components fail when imported
2 participants