Set up pre-commit hooks and added configuration files

[Al-an-21]

PR introduces pre-commit hooks and updates the layer.conf file to ensure compatibility with the specified Yocto series.

[artur-rs]

@Al-an-21 CI breaks on this step, let's check whether it's needed here/on this repo

[macpijan]

This skip makes sense only if we use shellcheck later in the hooks. Here we do not use it, so it complains it does not know which hook to skip, since it is not defined.

[Al-an-21]

According to this comment from Paweł, I was under the impression that the setup was correct. However, I’ve noticed that CI is not currently configured for this repository. Clarification on which specific step might be causing issues, as well as any particular requirements for the CI process, would be really helpful.

Additionally, I’ve observed similar failures in other PRs, like here, where it also fails.

At this point, I’m feeling a bit unsure about the situation and what the appropriate next steps should be. Any guidance or insight would be greatly appreciated.

[macpijan]

However, I’ve noticed that CI is not currently configured for this repository.

What makes you think so?

Clarification on which specific step might be causing issues, as well as any particular requirements for the CI process, would be really helpful.

Error logs from CI are really helpful in this matter: https://results.pre-commit.ci/run/github/884699586/1731079763.yDE45quGRTSrFpXri4k-0g

==> File .pre-commit-config.yaml
==> At Config()
==> At key: ci
==> At key: skip
=====> unexpected hook ids: shellcheck

So you should simply remove this: https://github.com/zarhus/meta-coreboot/pull/1/files#r1834676377

It's been suggested by @artur-rs 4 days ago as a solution to your problem already.

Sounds to me like shellcheck is used in skip, but is never defined.

[PLangowski]

I didn't notice the mistake in the config. I wonder why there were no errors when I ran the pre-commit locally.
@macpijan Do we not expect any shell scripts in this repo?

[macpijan]

I wonder why there were no errors when I ran the pre-commit locally.

Because it is in the ci section, which is relevant for pre-commit.ci only.

Do we not expect any shell scripts in this repo?

I do not think so. Definitely not at the moment.

[PLangowski]

Maybe you shouldn't delete the entire section? Just skip: [shellcheck]. Also, you should delete it instead of commenting it out