Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upload missing translations #557

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

gosiexon-zen
Copy link
Contributor

@gosiexon-zen gosiexon-zen commented Dec 19, 2024

Description

We added new aria-labels to support accessibility in Attachment Field in New Request Form. Now we are uploading translations for this labels.

Jira issue: GG-4037

Screenshots

Checklist

  • 📗 all commit messages follow the conventional commits standard
  • ⬅️ changes are compatible with RTL direction
  • ♿ Changes to the UI are tested for accessibility and compliant with WCAG 2.1.
  • 📝 changes are tested in Chrome, Firefox, Safari and Edge
  • 📱 changes are responsive and tested in mobile
  • 👍 PR is approved by @zendesk/vikings

@gosiexon-zen gosiexon-zen requested a review from a team as a code owner December 19, 2024 13:32
Fredx87
Fredx87 previously approved these changes Dec 19, 2024
Copy link
Contributor

@Fredx87 Fredx87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to put fix as commit type, otherwise we will not release a new version

@Fredx87 Fredx87 dismissed their stale review December 19, 2024 13:40

see other comment

@gosiexon-zen gosiexon-zen force-pushed the mbien/upload-translations branch from 122a6b9 to af29cbd Compare December 20, 2024 12:51
@gosiexon-zen gosiexon-zen force-pushed the mbien/upload-translations branch from af29cbd to ea4271c Compare January 7, 2025 11:12
@gosiexon-zen gosiexon-zen force-pushed the mbien/upload-translations branch from ea4271c to f811fd5 Compare January 7, 2025 13:31
@gosiexon-zen gosiexon-zen merged commit f33cd7b into master Jan 7, 2025
5 checks passed
@gosiexon-zen gosiexon-zen deleted the mbien/upload-translations branch January 7, 2025 13:36
@zd-svc-github-copenhagen-theme
Copy link
Collaborator

🎉 This PR is included in version 4.2.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants