Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(i18n): added shared translation string #565

Merged
merged 1 commit into from
Jan 16, 2025
Merged

chore(i18n): added shared translation string #565

merged 1 commit into from
Jan 16, 2025

Conversation

Fredx87
Copy link
Contributor

@Fredx87 Fredx87 commented Jan 16, 2025

Description

This PR adds the new cph-theme-shared.close-label translation string on master, so it can be translated

Screenshots

Checklist

  • 📗 all commit messages follow the conventional commits standard
  • ⬅️ changes are compatible with RTL direction
  • ♿ Changes to the UI are tested for accessibility and compliant with WCAG 2.1.
  • 📝 changes are tested in Chrome, Firefox, Safari and Edge
  • 📱 changes are responsive and tested in mobile
  • 👍 PR is approved by @zendesk/vikings

@Fredx87 Fredx87 requested a review from a team as a code owner January 16, 2025 08:52
@kubraokcu kubraokcu added the g11n-approved Commented by Globalization label label Jan 16, 2025
@Fredx87 Fredx87 merged commit d74e3b3 into master Jan 16, 2025
5 checks passed
@Fredx87 Fredx87 deleted the gianluca/new-shared-string branch January 16, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubraokcu kubraokcu kubraokcu approved these changes

@BrunoBFerreira BrunoBFerreira BrunoBFerreira approved these changes

Assignees
No one assigned
Labels
g11n-approved Commented by Globalization label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fredx87 @BrunoBFerreira @kubraokcu