-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade rdkafka
~> 0.15; require Ruby 3.0 since 2.6 is EOL
#366
Upgrade rdkafka
~> 0.15; require Ruby 3.0 since 2.6 is EOL
#366
Conversation
@tednology you might as well directly go to 3.0 because I am dropping support for 2.7 soon: karafka/rdkafka-ruby#374 |
rdkafka
~> 0.15; require Ruby 2.7 since 2.6 is EOLrdkafka
~> 0.15; require Ruby 3.0 since 2.6 is EOL
@mensfeld Done. |
No need to ping me. It's not my framework and I don't have merge permissions here ;) it was just a friendly advise from rdkafka maintainer. |
Hah, well, thanks anyway 😄. @deepredsky or @dasch, sorry for the ping, would it be possible to review this small upgrade? We don't need the minimum Ruby version requirement @ 3.0 (2.7 will suffice) if it's a concern. |
@tednology thanks for this pull request. I need to double check that upgrading rdkafka will not require any additional changes. +1 to dropping 2.6 support |
@deepredsky it will not. 0.15.0 is fully backwards compatible with 0.13 though I did change several timeouts to higher values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tednology can u add a changelog entry and also fixup the commit about lockfile. I will release a new beta with this tomorrow
You bet! |
7f24961
to
593d41e
Compare
@deepredsky can you please release a new beta with this change? 🙏 |
hi @jandudulski new beta is released. Also wanted to mention that you don't have to wait for beta versions to be released to use in ur project, you can use bundler's git feature to test the unreleased changes :) |
Thank you @deepredsky . Unfortunately, I have to bump it in another lib that is built on top of racecar, and this makes things a little bit more complicated to test 😀 |
What
This PR completes a couple of housekeeping items:
rdkafka-ruby
soon, too)rdkafka
to~> 0.15.0
I noticed that
rdkafka
0.15.0 minimum Ruby is 2.7 anyway.