Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update our CIs #22

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Update our CIs #22

merged 2 commits into from
Jan 31, 2025

Conversation

Vico1993
Copy link
Contributor

@Vico1993 Vico1993 commented Jan 24, 2025

Description

We always had issue in the past.

on:
    release:
        types:
            - released

It's never triggered when the release is created.

So I propose to merge both ci files together.
When we merge on the main branch, when the release is created

  • Update the ci bump action to not run when we update yml files

How to manually test

  1. Merge a change on main
  2. Notice the deployment working

Include label

We are following this pattern to keep our package version updated. Please add the appropriate label to your Pull requests between the following:

  • Version: Patch

Acceptation criteria

  • Added the corrected label to my pull request
  • Added/updated tests impacted by the change
  • Documentation is up-to-date (README.md / INSTALL.md)
  • [xx] Manually tested?

@Vico1993 Vico1993 added the bug Something isn't working label Jan 24, 2025
@Vico1993 Vico1993 self-assigned this Jan 24, 2025
@Vico1993 Vico1993 changed the title ci(main): Update the flow to automaticly merge / deploy package on main Update our CIs Jan 24, 2025
@Vico1993 Vico1993 added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit 846e159 Jan 31, 2025
3 checks passed
@Vico1993 Vico1993 deleted the victor.piolin/ci-update-main branch January 31, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants