Draft: [postal-savings-rs] Card transactions #743
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osipxd
force-pushed
the
postal-savings/card-transactions
branch
from
d1018d7 to
f0a2f7f
Compare
osipxd
commented
Apr 14, 2024
src/plugins/postal-savings-rs/__tests__/converters/transactions/cardTransactions.test.ts
Outdated
Show resolved
Hide resolved
osipxd
force-pushed
the
postal-savings/card-transactions
branch
from
f0a2f7f to
b434910
Compare
osipxd
commented
Apr 22, 2024
Comment on lines
+24
to
+31
| return { | ||
| ...account, | ||
| cardNumber, | ||
| rawData | ||
| } |
There was a problem hiding this comment.
I'm not sure if I'm doing the right thing here. Is it legal to attach data to an account this way? Will it be better to create wrapper-type instead, to not pass rawData to ZenMoney?
I'm sorry, it's my first time I'm using TypeScript, so I'm not sure about some constructions.
osipxd
force-pushed
the
postal-savings/card-transactions
branch
from
b434910 to
67a8dde
Compare
osipxd
commented
Apr 22, 2024
| import { Transaction } from '../../types/zenmoney' | ||
|
|
||
| function accountCardKey (accountId: string): string { | ||
| return `account/${accountId}/card` |
There was a problem hiding this comment.
Here are two options for the key format:
account/{accountId}/cardaccountCard/{accountId}
I've picked the first one because it allows us to bind other data to an account if it is needed
osipxd
force-pushed
the
postal-savings/card-transactions
branch
from
c112900 to
e2d2698
Compare
osipxd
force-pushed
the
postal-savings/card-transactions
branch
from
e2d2698 to
ece09b6
Compare
osipxd
force-pushed
the
postal-savings/card-transactions
branch
from
ece09b6 to
a9cb6aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #742
TODO:
Nice to have:
ATMPSBas cash withdrawal with zero fee