Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: wifi: nxp: Fix the compilation error on the MIMXRT1170_EVK board with the NXP_88W8987_MURATA_1ZM_M2 WiFi module #83092

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

CsBoBoNice
Copy link
Contributor

drivers: wifi: nxp: Fix the compilation error on the MIMXRT1170_EVK board with the NXP_88W8987_MURATA_1ZM_M2 WiFi module

  • Fix the compilation error on the MIMXRT1170_EVK board with the NXP_88W8987_MURATA_1ZM_M2 WiFi module

…oard with the NXP_88W8987_MURATA_1ZM_M2 WiFi module

- Fix the compilation error on the MIMXRT1170_EVK board with the NXP_88W8987_MURATA_1ZM_M2 WiFi module

Signed-off-by: csbobo <[email protected]>
@zephyrbot
Copy link
Collaborator

zephyrbot commented Dec 17, 2024

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@d2e2514 (master) zephyrproject-rtos/hal_nxp#489 zephyrproject-rtos/hal_nxp#489/files

Additional metadata changed:

Name URL Submodules West cmds module.yml
hal_nxp

DNM label due to: 1 project with PR revision and 1 project with metadata changes

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Dec 17, 2024
…oard with the NXP_88W8987_MURATA_1ZM_M2 WiFi module

- Modify the west.yml file.

Signed-off-by: csbobo <[email protected]>
if (params->mode == WIFI_PS_MODE_WMM) {
#if CONFIG_NXP_WIFI_WMM_UAPSD
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#if CONFIG_NXP_WIFI_WMM_UAPSD
#ifdef CONFIG_NXP_WIFI_WMM_UAPSD

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for other #if CONFIG_NXP_WIFI_WMM_UAPSD

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This modification was added to prevent compilation errors when the “Disable WMM feature” configuration is applied.

CONFIG_NXP_WIFI_DRIVER_TASK_STACK_SIZE=4096
CONFIG_NXP_WIFI_SCAN_TASK_STACK_SIZE=4096

# Disable WMM feature
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why need this Disable WMM feature part?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During the device testing process, I encountered an issue where the device failed to operate normally. My initial assessment suggested that the problem might be due to the CONFIG_NXP_WIFI_WMM configuration being enabled (although later verification revealed this not to be the case). To test this hypothesis, I attempted to disable the configuration, but encountered compilation errors. To resolve this issue, I added the aforementioned macro definitions. After thorough testing, it was confirmed that these new codes do not affect the functionality of the original code, therefore I have retained these modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Networking area: Samples Samples area: Wi-Fi Wi-Fi DNM This PR should not be merged (Do Not Merge) manifest manifest-hal_nxp platform: NXP Drivers NXP Semiconductors, drivers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants