-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: wifi: nxp: Fix the compilation error on the MIMXRT1170_EVK board with the NXP_88W8987_MURATA_1ZM_M2 WiFi module #83092
base: main
Are you sure you want to change the base?
Conversation
…oard with the NXP_88W8987_MURATA_1ZM_M2 WiFi module - Fix the compilation error on the MIMXRT1170_EVK board with the NXP_88W8987_MURATA_1ZM_M2 WiFi module Signed-off-by: csbobo <[email protected]>
The following west manifest projects have changed revision in this Pull Request:
Additional metadata changed:
⛔ DNM label due to: 1 project with PR revision and 1 project with metadata changes Note: This message is automatically posted and updated by the Manifest GitHub Action. |
…oard with the NXP_88W8987_MURATA_1ZM_M2 WiFi module - Modify the west.yml file. Signed-off-by: csbobo <[email protected]>
if (params->mode == WIFI_PS_MODE_WMM) { | ||
#if CONFIG_NXP_WIFI_WMM_UAPSD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#if CONFIG_NXP_WIFI_WMM_UAPSD | |
#ifdef CONFIG_NXP_WIFI_WMM_UAPSD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same for other #if CONFIG_NXP_WIFI_WMM_UAPSD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This modification was added to prevent compilation errors when the “Disable WMM feature” configuration is applied.
CONFIG_NXP_WIFI_DRIVER_TASK_STACK_SIZE=4096 | ||
CONFIG_NXP_WIFI_SCAN_TASK_STACK_SIZE=4096 | ||
|
||
# Disable WMM feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why need this Disable WMM feature
part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During the device testing process, I encountered an issue where the device failed to operate normally. My initial assessment suggested that the problem might be due to the CONFIG_NXP_WIFI_WMM configuration being enabled (although later verification revealed this not to be the case). To test this hypothesis, I attempted to disable the configuration, but encountered compilation errors. To resolve this issue, I added the aforementioned macro definitions. After thorough testing, it was confirmed that these new codes do not affect the functionality of the original code, therefore I have retained these modifications.
drivers: wifi: nxp: Fix the compilation error on the MIMXRT1170_EVK board with the NXP_88W8987_MURATA_1ZM_M2 WiFi module