I2s loopback config #83718
Merged
I2s loopback config #83718
+101
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
anangl,
dbaluta,
decsny,
dleach02,
manuargue and
mmahadevan108
Raymond0225
force-pushed
the
i2s_loopback_config
branch
2 times, most recently
from
9c76380 to
e92a8c4
Compare
|
@Raymond0225 add an update to this PR the west.yml to point to the needed HAL PR. |
To my understanding, we need merge the HAL PR firstly then update the full SHA in west.yml, right? |
Raymond0225
force-pushed
the
i2s_loopback_config
branch
from
fa92417 to
a005850
Compare
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
|
Resolve conflict with last main source code, rebase to latest code of upstream. |
Raymond0225
force-pushed
the
i2s_loopback_config
branch
from
a005850 to
2cd7196
Compare
DerekSnell
force-pushed
the
i2s_loopback_config
branch
2 times, most recently
from
baa6fb3 to
793c180
Compare
decsny
reviewed
Jan 14, 2025
drivers/i2s/i2s_mcux_sai.c
Outdated
| @@ -308,11 +308,23 @@ static void i2s_dma_tx_callback(const struct device *dma_dev, void *arg, uint32_ | |||
| /* TX queue has drained */ | |||
| strm->state = I2S_STATE_READY; | |||
| LOG_DBG("TX stream has stopped"); | |||
| goto disabled_exit_no_drop; | |||
| } else { | |||
There was a problem hiding this comment.
I think the else might not be necessary, should we remove it to reduce nesting since you're adding a new conditional within this block?
There was a problem hiding this comment.
yes, we can remove it.
Raymond0225
force-pushed
the
i2s_loopback_config
branch
from
793c180 to
872df4f
Compare
EmilioCBen
previously approved these changes
Jan 15, 2025
tests/drivers/i2s/i2s_speed/boards/mimxrt1170_evk_mimxrt1176_cm7.overlay
Show resolved
Hide resolved
tests/drivers/i2s/i2s_speed/boards/mimxrt1170_evk_mimxrt1176_cm7_B.overlay
Show resolved
Hide resolved
mmahadevan108
force-pushed
the
i2s_loopback_config
branch
2 times, most recently
from
4b81cb6 to
fedd352
Compare
Use TX and RX blocks on SAI for i2s speed test, by this way we can avoid HW reworking. Update Readme file and DMA channel configuration in overlay file to avoid DMA channel conflict with other peripherals like UART. Signed-off-by: Raymond Lei <[email protected]>
In previous implementions, when there is no buffers in TX queue in a TX callback context, TX will be stopped immediately. It is not correct because there may still TX blocks in DMA TX transfer queue. TX should only be stopped when DMA queue is empty and no more in I2S TX queue. Another modification is to set correct TX water FIFO level. Signed-off-by: Raymond Lei <[email protected]>
mmahadevan108
force-pushed
the
i2s_loopback_config
branch
from
fedd352 to
4da6bf8
Compare
decsny
approved these changes
Jan 27, 2025
mmahadevan108
approved these changes
Jan 27, 2025
|
@anangl , can you help review. |
anangl
approved these changes
Jan 28, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
require this HAL patch to pass the test:
zephyrproject-rtos/hal_nxp#490