Add imx91evk SoC and board support. #84009

Zhiqiang-Hou · 2025-01-15T10:08:21Z

Add imx91evk SoC and board support.

Depends on:

Develop/mimx9131 support hal_nxp#497

zephyrbot · 2025-01-15T10:09:18Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_nxp	zephyrproject-rtos/hal_nxp@`c15dd51`	zephyrproject-rtos/hal_nxp#497	zephyrproject-rtos/hal_nxp#497/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

nordicjm · 2025-01-15T10:31:47Z

west.yml

-      revision: b5f6470ec7ccd7f1c9a2c929fa93eae9fb001d9e
+      revision: pull/497/head


manifest update must come before anything needing it

yes, will make it the first patch. Thanks

nordicjm · 2025-01-15T10:32:25Z

soc/nxp/imx/imx9/imx91/mmu_regions.c

+#include <zephyr/sys/util.h>
+
+static const struct arm_mmu_region mmu_regions[] = {
+


Suggested change

will remove it.

nordicjm · 2025-01-15T10:32:51Z

boards/nxp/imx91_evk/CMakeLists.txt

@@ -0,0 +1 @@
+# SPDX-License-Identifier: Apache-2.0


empty file can go

will drop it

nordicjm · 2025-01-15T10:32:58Z

boards/nxp/imx91_evk/board.cmake

@@ -0,0 +1 @@
+# SPDX-License-Identifier: Apache-2.0


empty file can go

yes, will drop it.

nordicjm · 2025-01-15T10:33:36Z

boards/nxp/imx91_evk/Kconfig.imx91_evk

+# SPDX-License-Identifier: Apache-2.0
+
+config BOARD_IMX91_EVK
+	select SOC_MIMX9131 if BOARD_IMX91_EVK_MIMX9131


is this board going to have other SoCs adding to it? If not, then

Suggested change

select SOC_MIMX9131 if BOARD_IMX91_EVK_MIMX9131

select SOC_MIMX9131

No other SoC, will take your suggestion. Thanks

nordicjm · 2025-01-15T10:34:19Z

boards/nxp/imx91_evk/doc/index.rst

+Supported Features
+==================
+
+The Zephyr imx91_evk board Cortex-A Core configuration supports the following


`` around board name, or better yet use full name as supplied to west build and call it board target

make sense, will update. thanks

nordicjm · 2025-01-15T10:34:34Z

boards/nxp/imx91_evk/imx91_evk_mimx9131.dts

+&lpuart1 {
+	status = "okay";
+	current-speed = <115200>;
+	/* clocks = <&ccm IMX_CCM_UART4_CLK 0x6c 24>; */


yes, will remove this line.

nordicjm · 2025-01-15T10:35:09Z

boards/nxp/imx91_evk/imx91_evk_mimx9131_defconfig

+# Zephyr Kernel Configuration
+CONFIG_XIP=n
+CONFIG_KERNEL_DIRECT_MAP=y


why can't SoC select/defconfig these?

I think it's better not select the XIP and DIRECT_MAP configs under SoC, these configs can be different in boards with the same SoC.

Currently there are some device drivers MMIO mapping uses direct map, so I also suggest to move it to SoC defconfig.

Zephyr device drivers should use the virtual address, so not depends on this config. This is for some freestanding applications that access the MMIO/RAM using physical address, such as the applications in our Real-time-edge.

So device driver are based on hal driver which need to use 1:1 mapping, so they are using K_MEM_DIRECT_MAP MMIP mapping flag, so depend on CONFIG_KERNEL_DIRECT_MAP.

Already move it to SoC Kconfig and select it on condition HAS_MCUX.

dleach02 · 2025-01-16T03:40:38Z

@JiafeiPan I'm adding you as an assignee

boards/nxp/imx91_evk/imx91_evk_mimx9131_defconfig

JiafeiPan · 2025-01-17T02:29:31Z

boards/nxp/imx91_evk/imx91_evk_mimx9131_defconfig

+# Zephyr Kernel Configuration
+CONFIG_XIP=n
+CONFIG_KERNEL_DIRECT_MAP=y


Currently there are some device drivers MMIO mapping uses direct map, so I also suggest to move it to SoC defconfig.

soc/nxp/imx/imx9/imx91/mmu_regions.c

dbaluta · 2025-01-17T08:25:18Z

west.yml

@@ -203,7 +203,7 @@ manifest:
      groups:


Please create a better description for this PR. When it will be merged there won't be any reference to PR497.

So please say something along the lines: update hal_nxp to pull support for imx91.

yes, will update with the info, actually it will be updated to the hal_nxp SHA when that PR is merged.

Update the hal_nxp revison to the depended PR support for mimx9131. Signed-off-by: Hou Zhiqiang <[email protected]>

Add DTSi file for i.MX91. Signed-off-by: Hou Zhiqiang <[email protected]>

The i.MX 91 SoC’s integrated EdgeLock® Secure Enclave provides security features including lifecycle management, tamper detection, secure boot and a simplified path to certifications. The i.MX 91 family features an Arm® Cortex®-A55 running at up to 1.4GHz, support for modern LPDDR4 memory to enable platform longevity, dual Gigabit Ethernet and dual USB ports, along with a rich set of peripherals targeting medical, industrial and consumer IoT market segments. Signed-off-by: Hou Zhiqiang <[email protected]>

Add clock driver support for MIMX9131. Signed-off-by: Hou Zhiqiang <[email protected]>

Add pinctrl driver support for MIMX9131. Signed-off-by: Hou Zhiqiang <[email protected]>

Zhiqiang-Hou · 2025-01-17T15:51:35Z

V2:

Rebased.
Removed some empty cmake files.
Moved the west.yml change patch to the first.
Refined the Kconfig.imx91_evk.
Refined the board doc.

V3:

Moved the selection of KERNEL_DIRECT_MAP to SoC Kconfig.
Reduced the MAX_XLAT_TABLES to 24.
Refined some change log.

The i.MX 91 Evaluation Kit (MCIMX91-EVK board) is a platform designed to display the most commonly used features of the i.MX 91 applications processor. The MCIMX91-EVK board is an entry-level development board with a small and low-cost package. Signed-off-by: Hou Zhiqiang <[email protected]>

Zhiqiang-Hou · 2025-01-21T13:48:03Z

V4:

Change the memory region to the dram start address 0x80000000.

zephyrbot added area: ARM64 ARM (64-bit) Architecture platform: NXP MPU area: Clock Control area: Pinctrl platform: NXP Drivers NXP Semiconductors, drivers labels Jan 15, 2025

zephyrbot requested review from carlocaione, dbaluta, decsny, dleach02, gmarull, iuliana-prodan, JiafeiPan, manuargue, mmahadevan108, nordic-krch, npitre, povergoing, SgrrZhf and yvanderv January 15, 2025 10:09

zephyrbot assigned dleach02 Jan 15, 2025

zephyrbot assigned mmahadevan108 Jan 15, 2025

zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Jan 15, 2025

nordicjm reviewed Jan 15, 2025

View reviewed changes

dleach02 assigned JiafeiPan and unassigned mmahadevan108 Jan 16, 2025

nashif changed the title ~~Develop/imx91 support~~ Add imx91evk SoC and board support. Jan 16, 2025

Zhiqiang-Hou force-pushed the develop/imx91-support branch from d2ad03c to 79a0244 Compare January 16, 2025 16:08

JiafeiPan reviewed Jan 17, 2025

View reviewed changes

dbaluta reviewed Jan 17, 2025

View reviewed changes

Zhiqiang-Hou added 5 commits January 17, 2025 17:30

west.yml: update hal_nxp to the pull-request support for mimx9131

162b377

Update the hal_nxp revison to the depended PR support for mimx9131. Signed-off-by: Hou Zhiqiang <[email protected]>

dts: arm64: nxp: add device tree for SoC imx91

dc6c8e4

Add DTSi file for i.MX91. Signed-off-by: Hou Zhiqiang <[email protected]>

drivers: clock: ccm_rev2: add imx91 support

51e7a47

Add clock driver support for MIMX9131. Signed-off-by: Hou Zhiqiang <[email protected]>

drivers: pinctrl_imx: add imx91 support

529712d

Add pinctrl driver support for MIMX9131. Signed-off-by: Hou Zhiqiang <[email protected]>

Zhiqiang-Hou force-pushed the develop/imx91-support branch from 79a0244 to 9b2cdc9 Compare January 17, 2025 15:34

decsny removed their request for review January 17, 2025 19:39

Zhiqiang-Hou force-pushed the develop/imx91-support branch from 9b2cdc9 to ebffa1a Compare January 21, 2025 13:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add imx91evk SoC and board support. #84009

Add imx91evk SoC and board support. #84009

Zhiqiang-Hou commented Jan 15, 2025 •

edited by dbaluta

Loading

zephyrbot commented Jan 15, 2025 •

edited

Loading

nordicjm Jan 15, 2025

Zhiqiang-Hou Jan 16, 2025

nordicjm Jan 15, 2025

Zhiqiang-Hou Jan 16, 2025

nordicjm Jan 15, 2025

Zhiqiang-Hou Jan 16, 2025

nordicjm Jan 15, 2025

Zhiqiang-Hou Jan 16, 2025

nordicjm Jan 15, 2025

Zhiqiang-Hou Jan 16, 2025

nordicjm Jan 15, 2025

Zhiqiang-Hou Jan 16, 2025

nordicjm Jan 15, 2025

Zhiqiang-Hou Jan 16, 2025

nordicjm Jan 15, 2025

Zhiqiang-Hou Jan 16, 2025

JiafeiPan Jan 17, 2025

Zhiqiang-Hou Jan 17, 2025

JiafeiPan Jan 20, 2025

Zhiqiang-Hou Jan 20, 2025

dleach02 commented Jan 16, 2025

JiafeiPan Jan 17, 2025

dbaluta Jan 17, 2025 •

edited

Loading

Zhiqiang-Hou Jan 17, 2025

Zhiqiang-Hou commented Jan 17, 2025

Zhiqiang-Hou commented Jan 21, 2025

		revision: b5f6470ec7ccd7f1c9a2c929fa93eae9fb001d9e
		revision: pull/497/head

		#include <zephyr/sys/util.h>

		static const struct arm_mmu_region mmu_regions[] = {

	select SOC_MIMX9131 if BOARD_IMX91_EVK_MIMX9131
	select SOC_MIMX9131

Add imx91evk SoC and board support. #84009

Are you sure you want to change the base?

Add imx91evk SoC and board support. #84009

Conversation

Zhiqiang-Hou commented Jan 15, 2025 • edited by dbaluta Loading

zephyrbot commented Jan 15, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dleach02 commented Jan 16, 2025

Choose a reason for hiding this comment

dbaluta Jan 17, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zhiqiang-Hou commented Jan 17, 2025

Zhiqiang-Hou commented Jan 21, 2025

Zhiqiang-Hou commented Jan 15, 2025 •

edited by dbaluta

Loading

zephyrbot commented Jan 15, 2025 •

edited

Loading

dbaluta Jan 17, 2025 •

edited

Loading