samples: Bluetooth: BAP: Broadcast sink use new USB stack #84359
+1,427
−532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
broadcast_sink_new_usb
branch
5 times, most recently
from
344781a to
0c74509
Compare
Thalley
changed the title
Thalley
force-pushed
the
broadcast_sink_new_usb
branch
6 times, most recently
from
2849e0e to
7f4ab01
Compare
Thalley
force-pushed
the
broadcast_sink_new_usb
branch
from
7f4ab01 to
94b3ac6
Compare
This was referenced Jan 28, 2025
USB: device_next: assert in udc_event_xfer_in when doing nrjfprof --reset on nRF5340 Audio DK
#84662
Open
Thalley
force-pushed
the
broadcast_sink_new_usb
branch
3 times, most recently
from
47bf2c0 to
98a937c
Compare
tmon-nordic
reviewed
Jan 30, 2025
Comment on lines
20
to
29
| uac_aclk: aclk { | ||
| compatible = "zephyr,uac2-clock-source"; | ||
| clock-type = "internal-programmable"; | ||
| frequency-control = "read-only"; | ||
| sampling-frequencies = <48000>; | ||
| }; |
There was a problem hiding this comment.
Just like in case of broadcast source, it would be good to have sof-synchronized; with appropriate comment here (the code does not actively decide when to send +-1 nominal samples to keep audio frames synchronized to SOF; in other words the code currently always sends fixed number of samples).
We certainly should not claim to be asynchronous audio when we are doing things "the old way". Just falsely claiming Synchronous audio is probably better because the Asynchronous audio has higher end-user expectations in general.
Refactor everything related to RX in the sample. The existing code will moved to new files with more specific functionality, so that each file will become cleaner and use fewer #ifdefs. The USB part will be refactored a bit to follow the design used by the LE audio shell, to make it easier to maintain both in a similar way. Signed-off-by: Emil Gydesen <[email protected]>
Refactor the USB of the BAP broadcast sink to use the new USB stack. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
broadcast_sink_new_usb
branch
from
98a937c to
7886c62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the USB of the BAP broadcast sink to use the new
USB stack.
Fixes #83054