samples: bluetooth: OpenDroneID #84565
Conversation
zephyrbot
added
area: Bluetooth
area: Bluetooth Host
This application demonstrates ODID Message transmission over Bluetooth in GAP Broadcaster role. Currently this program supports transmitting static drone data via Bluetooth Beacon. Co-authored-by: Mayank Mahajan <[email protected]> Signed-off-by: Sumit Batra <[email protected]>
zephyrbot
requested review from
alwa-nordic,
cvinayak,
hermabe,
jhedberg,
kartben,
nashif,
rugeGerritsen,
sjanc,
Thalley and
theob-pro
sumitbatra-nxp
force-pushed
the
kw45-odid
branch
from
8a5197b to
6d9c1b4
Compare
| * | ||
| * @param data (non encoded/packed) structure | ||
| */ | ||
| void odid_initLocationData(ODID_Location_data *data) |
| static struct ODID_UAS_Data uasData; | ||
| static union ODID_Message_encoded encoded; | ||
| static uint8_t msg_counters[ODID_MSG_COUNTER_AMOUNT]; |
There was a problem hiding this comment.
declare at top of file, in snake case
|
|
||
| uasData->BasicID[BASIC_ID_POS_ONE].UAType = ODID_UATYPE_HELICOPTER_OR_MULTIROTOR; | ||
| uasData->BasicID[BASIC_ID_POS_ONE].IDType = ODID_IDTYPE_SPECIFIC_SESSION_ID; | ||
| char uas_caa_id[] = "FD3454B778E565C24B70"; |
There was a problem hiding this comment.
declare variables at top
|
I'm wondering if this code belongs in the folder |
|
I would request all the reviewers to kindly review this PR despite of the LLVM/Twister errors since these errors cannot be resolved till PR #82034 is merged |
| while (true) { | ||
| if (bt_is_ready()) { | ||
| break; | ||
| } | ||
|
|
||
| printf("Bluetooth not ready. Checking again in 100 ms\n"); | ||
| k_sleep(K_MSEC(100)); | ||
| } |
There was a problem hiding this comment.
This does't look particularly elegant. You could instead have this wait on a semaphore that your bt_ready() callback eventually gives, however the bt_enable() API already has support for blocking behavior: you just need to pass NULL to it, and then do the stuff you do in your bt_ready() right here in main()
|
|
||
| update_payload(turn); | ||
|
|
||
| static const struct bt_data ad_new[] = { |
There was a problem hiding this comment.
Do you really need this new ad_new? Can't you just reuse the top-level ad?
|
Discussed in Bluetooth WG: this might make more sense in a separate repo under https://github.com/opendroneid/ |
Just to clarify: large applications are not the best fit under the Zephyr samples, since they come with a substantial maintenance burden, so having them independently maintained elsewhere may be preferable. |
Thanks for taking this up in the Bluetooth Working Group.. I acknowledge the recommendation and hence closing this PR, will add a new repo in the opendroneid project |
This application demonstrates ODID Message transmission over Bluetooth in GAP Broadcaster role. Currently this program supports transmitting static drone data via Bluetooth Beacon.
OpendroneID application can be used with the SoC and the Board support added in
PR #82034