-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpp: Add c++ version number #85009
Open
yperess
wants to merge
1
commit into
zephyrproject-rtos:main
Choose a base branch
from
yperess:peress/stdcpp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
cpp: Add c++ version number #85009
+21
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdgendt
reviewed
Feb 1, 2025
yperess
force-pushed
the
peress/stdcpp
branch
from
February 1, 2025 17:40
a680540
to
ac31c3a
Compare
cfriedt
previously approved these changes
Feb 1, 2025
pdgendt
reviewed
Feb 1, 2025
yperess
force-pushed
the
peress/stdcpp
branch
from
February 1, 2025 20:58
ac31c3a
to
76b4663
Compare
pdgendt
previously approved these changes
Feb 1, 2025
cfriedt
previously approved these changes
Feb 1, 2025
henrikbrixandersen
previously approved these changes
Feb 2, 2025
alexanderwachter
requested changes
Feb 2, 2025
alexanderwachter
requested changes
Feb 2, 2025
yperess
dismissed stale reviews from henrikbrixandersen, cfriedt, and pdgendt
via
February 2, 2025 16:40
bba2792
yperess
force-pushed
the
peress/stdcpp
branch
2 times, most recently
from
February 2, 2025 16:43
bba2792
to
150c9be
Compare
yperess
requested review from
alexanderwachter,
pdgendt,
henrikbrixandersen and
cfriedt
February 2, 2025 16:43
alexanderwachter
previously approved these changes
Feb 2, 2025
Several downstream libraries need to specify that they work with c++ 17+ or 20+ and there's no easy way to do this without constantly updating the Kconfig file and supporting different Kconfig versions for different Zephyr versions (since I can't add a dependency on a new c++ standard and have it backwards compatible. Signed-off-by: Yuval Peress <[email protected]>
yperess
force-pushed
the
peress/stdcpp
branch
from
February 2, 2025 17:24
150c9be
to
19fd7cd
Compare
I guess we can't use longs in Kconfig ints. |
alexanderwachter
approved these changes
Feb 2, 2025
cfriedt
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several downstream libraries need to specify that they work with c++ 17+ or 20+ and there's no easy way to do this without constantly updating the Kconfig file and supporting different Kconfig versions for different Zephyr versions (since I can't add a dependency on a new c++ standard and have it backwards compatible.