stm32 comparator #85022
Open
stm32 comparator #85022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
djiatsaf-st,
erwango,
FRASTM,
gautierg-st,
GeorgeCGV,
kartben,
marwaiehm-st,
mathieuchopstm and
nashif
jilaypandya
reviewed
Feb 2, 2025
drivers/comparator/CMakeLists.txt
Outdated
| @@ -9,5 +9,6 @@ zephyr_library_sources_ifdef(CONFIG_USERSPACE comparator_handlers.c) | |||
| zephyr_library_sources_ifdef(CONFIG_COMPARATOR_FAKE_COMP comparator_fake_comp.c) | |||
| zephyr_library_sources_ifdef(CONFIG_COMPARATOR_MCUX_ACMP comparator_mcux_acmp.c) | |||
| zephyr_library_sources_ifdef(CONFIG_COMPARATOR_NRF_COMP comparator_nrf_comp.c) | |||
| zephyr_library_sources_ifdef(CONFIG_COMPARATOR_STM32_COMP comparator_stm32_comp.c) | |||
drivers/comparator/Kconfig
Outdated
| @@ -21,6 +21,7 @@ config COMPARATOR_INIT_PRIORITY | |||
| rsource "Kconfig.fake_comp" | |||
| rsource "Kconfig.mcux_acmp" | |||
| rsource "Kconfig.nrf_comp" | |||
| rsource "Kconfig.stm32_comp" | |||
KozhinovAlexander
force-pushed
the
stm32_comparator
branch
5 times, most recently
from
7cc8784 to
455e0ec
Compare
Add comparator sample with simple triggering behaviour Signed-off-by: Alexander Kozhinov <[email protected]>
Add comparator driver for ST's stm32 series. Signed-off-by: Alexander Kozhinov <[email protected]>
KozhinovAlexander
force-pushed
the
stm32_comparator
branch
from
455e0ec to
8dd5b55
Compare
bjarki-andreasen
requested changes
Feb 3, 2025
There was a problem hiding this comment.
The driver looks good :) The sample is not needed I believe. The test suite in tests/drivers/comparator/gpio_loopback validates the API behavior with a GPIO connected to the comp input. The build all test suite allows you to build varoius dt configurations tests/drivers/build_all/comparator, and lastly, given the nature of a comparator, just enabling the comparator shell in a blank application is sample enough :)
Please add the comp to the two test suites to validate and build the driver in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add stm32 comparator driver and simple comparator sample.
I've used to test it on nucleo_h745zi_q (m7 core only).
Build command with newly added sample:
My build result output:
-- Zephyr version: 4.0.99 (...../zephyr), build: v4.0.0-4417-g2c7031229fe0 [153/153] Linking C executable zephyr/zephyr.elf Memory region Used Size Region Size %age Used FLASH: 31316 B 1 MB 2.99% RAM: 6848 B 512 KB 1.31% EXTMEM: 0 GB 256 MB 0.00% SRAM1: 0 GB 128 KB 0.00% SRAM2: 0 GB 128 KB 0.00% SRAM3: 16 KB 32 KB 50.00% SRAM4: 0 GB 64 KB 0.00% DTCM: 0 GB 128 KB 0.00% IDT_LIST: 0 GB 32 KB 0.00%The resulting output in the console could look like:
NOTE: To see the output value changing and
comp_trigger_cbcalled the pins PB0 and PB2 shall be connected physically on the nucleo_h745zi_q board. Please consider the overlay file in the sample to find more about pinouts used.I've not tested the driver with any other stm32, but I am planning to add support for stm32g4 soon.
Any testers with appropriate board (any stm32h7 would be fine as a good first choice) are very welcome.