Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SimpleSpan method headers #721

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Fix SimpleSpan method headers #721

merged 4 commits into from
Jan 29, 2025

Conversation

benjamin-cates
Copy link
Contributor

@benjamin-cates benjamin-cates commented Jan 28, 2025 •
edited
Loading

Changelog

  • Remove SimpleSpan::new, which can be replaced with ::new
  • Remove SimpleSpan::splat
  • Update SimpleSpan into range or into iterator to support contexts

Fixes: #719

zesterer
zesterer requested changes Jan 28, 2025
View reviewed changes
Copy link
Owner

@zesterer zesterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadly happy with this PR, but I'm squirming a bit about the change to the From impl. Thanks for opening!

src/span.rs Outdated Show resolved Hide resolved
@zesterer zesterer merged commit 10a8755 into zesterer:main Jan 29, 2025
4 checks passed
@zesterer
Copy link
Owner

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zesterer zesterer zesterer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SimpleSpan::new method name conflict
2 participants
@benjamin-cates @zesterer