Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MFA Server Definitions #1740

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

andy-maier
Copy link
Member

@andy-maier andy-maier commented Jan 22, 2025

For details, see the commit message.

@andy-maier andy-maier self-assigned this Jan 22, 2025
@andy-maier andy-maier added this to the 1.19.0 milestone Jan 22, 2025
@andy-maier andy-maier linked an issue Jan 22, 2025 that may be closed by this pull request
@andy-maier andy-maier force-pushed the andy/mfa-server-definitions branch from 771466c to ea03f56 Compare January 22, 2025 10:16
@andy-maier andy-maier changed the title [WIP] Support for MFA Server Definitions Support for MFA Server Definitions Jan 22, 2025
@andy-maier andy-maier force-pushed the andy/mfa-server-definitions branch from ea03f56 to 5bf6088 Compare January 22, 2025 10:21
Details:

* Added support for MFA Server Definitions with a new
  'zhmcclient.MfaServerDefinition' resource class (and a corresponding manager
  class).

* Added zhmcclient mock support for MFA Server Definitions with a new
  'zhmcclient_mock.FakedMfaServerDefinition' resource class (and a corresponding
  manager class).

* Added unit testcases for the new zhmcclient and zhmcclient_mock classes.

* Added end2end testcases for the new zhmcclient classes.

Signed-off-by: Andreas Maier <[email protected]>
@andy-maier andy-maier force-pushed the andy/mfa-server-definitions branch from 5bf6088 to 3954db0 Compare January 22, 2025 11:25
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 82.651% (+0.1%) from 82.504%
when pulling 3954db0 on andy/mfa-server-definitions
into 873a68d on master.

Copy link
Contributor

@EdGue42 EdGue42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good (didn't check the test in depth though)

@andy-maier andy-maier merged commit ca4cd5d into master Jan 22, 2025
15 checks passed
@andy-maier andy-maier deleted the andy/mfa-server-definitions branch January 22, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for MFA Server Definition resource
3 participants