Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added zhmc_cpc_capacity module #234

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Added zhmc_cpc_capacity module #234

merged 1 commit into from
Jul 8, 2024

Conversation

andy-maier
Copy link
Member

@andy-maier andy-maier commented Nov 13, 2020 •
edited
Loading

Re-implemented the module since the last review.
Requires a full re-review.

Particular review points:

  • This new module returns its properties with underscores in the property names.

Worked through answers on channel: https://ibm-systems-z.slack.com/archives/C3XE4H56X/p1707739938954879

Tests (on 2024-07-03 with commit cf21ce7):

  • Ran the new end2end testcase for state=facts for A224 - passed
  • Manually ran a test playbook for state=facts for A224 - had the expected result values
  • Manually ran a test playbook for state=set in check mode for A224 - showed the expected changes
  • Manually ran a test playbook for state=set in non-check mode for A224 - showed reasonable errors for the non-existing capacity record.

@andy-maier andy-maier self-assigned this Nov 13, 2020
@andy-maier andy-maier added this to the 1.1.0 milestone Nov 13, 2020
@coveralls
Copy link

coveralls commented Nov 13, 2020 •
edited
Loading

Coverage Status

coverage: 43.773% (-0.2%) from 44.003%
when pulling 08bed4a on 1.1/andy/cpc_capacity
into 32a0579 on master.

@andy-maier andy-maier force-pushed the 1.1/andy/cpc_capacity branch 3 times, most recently from b4f6fec to 19ad2d8 Compare November 13, 2020 15:33
@andy-maier andy-maier linked an issue Nov 19, 2020 that may be closed by this pull request
Add module for managing temporary capacity of a CPC #243
Closed
@andy-maier andy-maier force-pushed the 1.1/andy/cpc_capacity branch 3 times, most recently from 7fe15d8 to 1fd4957 Compare November 27, 2020 16:21
@andy-maier andy-maier changed the title [WIP] 1.1: Added zhmc_cpc_capacity module [WIP] 0.10.0: Added zhmc_cpc_capacity module Dec 12, 2020
@andy-maier andy-maier changed the title [WIP] 0.10.0: Added zhmc_cpc_capacity module [WIP] Added zhmc_cpc_capacity module Dec 14, 2020
@andy-maier andy-maier force-pushed the 1.1/andy/cpc_capacity branch 3 times, most recently from 7965ecc to 49e265c Compare December 20, 2020 15:30
@andy-maier andy-maier mentioned this pull request Dec 20, 2020
Open
@andy-maier andy-maier force-pushed the 1.1/andy/cpc_capacity branch from 49e265c to ff101cc Compare March 23, 2021 20:54
@andy-maier andy-maier force-pushed the 1.1/andy/cpc_capacity branch 5 times, most recently from d3c691e to 0fec48c Compare April 7, 2021 20:29
@andy-maier andy-maier changed the title [WIP] Added zhmc_cpc_capacity module Added zhmc_cpc_capacity module Apr 7, 2021
vkathir82
vkathir82 requested changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@vkathir82 vkathir82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need update in the documentation side as specified

docs/source/modules/zhmc_cpc_capacity.rst Show resolved Hide resolved
docs/source/modules/zhmc_cpc_capacity.rst Show resolved Hide resolved
docs/source/modules/zhmc_cpc_capacity.rst Show resolved Hide resolved
@andy-maier andy-maier force-pushed the 1.1/andy/cpc_capacity branch from 53fe16c to 703aae1 Compare June 24, 2024 16:12
@andy-maier andy-maier force-pushed the 1.1/andy/cpc_capacity branch 3 times, most recently from a2c1884 to 03e2854 Compare July 3, 2024 10:37
@andy-maier andy-maier requested a review from anilak11 July 3, 2024 10:39
@andy-maier andy-maier force-pushed the 1.1/andy/cpc_capacity branch from 03e2854 to cf21ce7 Compare July 3, 2024 10:59
@andy-maier
Copy link
Member Author

andy-maier commented Jul 3, 2024 •
edited
Loading

I worked through the discussion in the slack channel and made several changes based on that. Also, I accommodated for the fact that some capacity related CPC properties were introduced only on SE 2.16.0.

Requires re-review - I have reset the review status.

@andy-maier andy-maier force-pushed the 1.1/andy/cpc_capacity branch 4 times, most recently from f1f9f46 to 2a3d8d8 Compare July 4, 2024 08:41
@andy-maier andy-maier force-pushed the 1.1/andy/cpc_capacity branch 3 times, most recently from c8d6824 to cb28d00 Compare July 6, 2024 03:14
simon-spinner
simon-spinner reviewed Jul 8, 2024
View reviewed changes
plugins/modules/zhmc_cpc_capacity.py Outdated Show resolved Hide resolved
plugins/modules/zhmc_cpc_capacity.py Outdated Show resolved Hide resolved
plugins/modules/zhmc_cpc_capacity.py Show resolved Hide resolved
@andy-maier andy-maier requested a review from simon-spinner July 8, 2024 13:12
@andy-maier andy-maier force-pushed the 1.1/andy/cpc_capacity branch from cb28d00 to 7c0e38b Compare July 8, 2024 13:13
@andy-maier
Added zhmc_cpc_capacity module
08bed4a 
Details:

* Added a new Ansible module 'zhmc_cpc_capacity' for managing the temporary
  processor capacity of a CPC. (issue #243)

* Added end2end testcase for zhmc_cpc_capacity with state=facts.

Signed-off-by: Andreas Maier <[email protected]>
@andy-maier andy-maier force-pushed the 1.1/andy/cpc_capacity branch from 7c0e38b to 08bed4a Compare July 8, 2024 14:09
@andy-maier andy-maier merged commit b481745 into master Jul 8, 2024
16 checks passed
@andy-maier andy-maier deleted the 1.1/andy/cpc_capacity branch July 8, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-spinner simon-spinner simon-spinner approved these changes

@vkathir82 vkathir82 Awaiting requested review from vkathir82

@saiprasanna-16 saiprasanna-16 Awaiting requested review from saiprasanna-16

@kavinrajam kavinrajam Awaiting requested review from kavinrajam

@anilak11 anilak11 Awaiting requested review from anilak11

Assignees

@andy-maier andy-maier

Labels
None yet
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Add module for managing temporary capacity of a CPC
5 participants
@andy-maier @coveralls @simon-spinner @vkathir82 @anilak11