Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split schnorr + ecdsa sign impl + recovery #10

Merged
merged 8 commits into from
Sep 10, 2024
Merged

Conversation

StringNick
Copy link
Collaborator

@StringNick StringNick commented Sep 9, 2024

Refactoring
Ecdsa + recovery impl
Fixed error

@StringNick StringNick changed the title Draft: split schnorr + ecdsa sign impl Split schnorr + ecdsa sign impl + recovery Sep 10, 2024
Copy link
Contributor

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments

build.zig Outdated Show resolved Hide resolved
build.zig Outdated Show resolved Hide resolved
src/ecdsa/ecdsa.zig Outdated Show resolved Hide resolved
src/ecdsa/ecdsa.zig Show resolved Hide resolved
Copy link
Contributor

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AbdelStark AbdelStark merged commit 4036f3a into main Sep 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants