Udpate to ImGui v1.91.8. #15
Conversation
|
Thanks for the great work! I ran my demo app on adbe991.
Its unfortunate that the node editor hasn't updated in a very long time. Generally we are deviating from the original source for small fixes to keep this bundle of libraries working, and I think your change is aligned with that 👍 |
| // (Optional) Dynamic Rendering | ||
| // Need to explicitly enable VK_KHR_dynamic_rendering extension to use this, even for Vulkan 1.3. | ||
| bool UseDynamicRendering; | ||
| #ifdef IMGUI_IMPL_VULKAN_HAS_DYNAMIC_RENDERING | ||
| VkPipelineRenderingCreateInfoKHR PipelineRenderingCreateInfo; | ||
| #else | ||
| unusedVkPipelineRenderingCreateInfo PipelineRenderingCreateInfo; |
There was a problem hiding this comment.
This needs to be re-introduced as not having this structure breaks compatibility. We would like to have stable structure to be consumed from Zig regardless of IMGUI_IMPL_VULKAN_HAS_DYNAMIC_RENDERING, which is the reason the unusedVkPipelineRenderingCreateInfo was introduced with identical memory structure.
IMGUI_IMPL_VULKAN_HAS_DYNAMIC_RENDERING depends on the availability of Vulkan 1.3 support and dynamic rendering visible in vulkan_core.h which is not necessarily present for all devices.
#if defined(VK_VERSION_1_3) || defined(VK_KHR_dynamic_rendering) #define IMGUI_IMPL_VULKAN_HAS_DYNAMIC_RENDERING #endif
I recommend adding the following comment // FIX(zig-gamedev) - Match PipelineRenderingCreateInfo structure for compatibility above it as well to prevent future accidental removals when this backend gets updated again.
There was a problem hiding this comment.
Re-applied the patch and added the comment. Thanks a lot for the background.
| cbv_srv_heap: *const anyopaque, // ID3D12DescriptorHeap | ||
| font_srv_cpu_desc_handle: backend_dx12.D3D12_CPU_DESCRIPTOR_HANDLE, | ||
| font_srv_gpu_desc_handle: backend_dx12.D3D12_GPU_DESCRIPTOR_HANDLE, | ||
| init_info: backend_dx12.ImGui_ImplDX12_InitInfo, |
There was a problem hiding this comment.
API break. Worth doing this sooner rather than later 👍
| cbv_srv_heap: *const anyopaque, // ID3D12DescriptorHeap* | ||
| font_srv_cpu_desc_handle: backend_dx12.D3D12_CPU_DESCRIPTOR_HANDLE, | ||
| font_srv_gpu_desc_handle: backend_dx12.D3D12_GPU_DESCRIPTOR_HANDLE, | ||
| init_info: backend_dx12.ImGui_ImplDX12_InitInfo, |
There was a problem hiding this comment.
Another to fixup in d3d12 samples.
|
Nice job. I tested the samples on macOS and Linux. I will fixup the D3D12 samples. Thanks! |
zgui D3d12 backend breaking change introduced by upgrade to Dear Imgui 1.91.8. See zig-gamedev/zgui#15
Updated all ImGui C++ files to the latest version: https://github.com/ocornut/imgui/tree/v1.91.8/. As described in #13, this is useful to add support for the SDL3+GPU backend. Here's a few things to note:
'vulkan/vulkan.h' file not found, maybe I'm missing something on my machine). It would be nice if you have the bandwidth to rerun your demo with those changes as a sanity check before merging this PR.Finally, this is a pretty large change that risk introducing a bunch of bugs. I'm open to feedback or running some additional tests if you can point me in the right direction.