Try to fix parts/quits now causing Bucket to crash #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Someone parting or getting kicked now causes Bucket to crash with an error about treating an undefined value as an ARRAY reference. I can only assume some subtle behavior changes have happened in the years and Perl versions since I last ran this code, and something that used to be allowed is no longer kosher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone parting or getting kicked now causes Bucket to crash with an error about treating an undefined value as an ARRAY reference.
I can only assume some subtle behavior changes have happened in the years and Perl versions since I last ran this code, and something that used to be allowed is no longer kosher. There were no issues initially with #129 (where these
ifblocks came from) or I'm positive I wouldn't have merged the patch.