-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ingressClass #109
Conversation
Welcome @cin-logan! It looks like this is your first PR to zilliztech/milvus-helm 🎉 |
f234c09
to
95e9ff1
Compare
Hi @cin-logan, it would be better to add an default empty string value in |
/approve |
317e618
to
0ed3fcc
Compare
could you help me to review it again ? thanks @haorenfsa |
@cin-logan looks good, please bump the chart version to 4.2.1. And we're ready to merge it. |
Signed-off-by: cin-logan <[email protected]>
Signed-off-by: cin-logan <[email protected]>
Signed-off-by: cin-logan <[email protected]>
26fefea
to
ddb9ef4
Compare
Sorry for the inconvenience, I have force-pushed again 😢. Could you check it, @haorenfsa |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cin-logan, haorenfsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What this PR does / why we need it:
Since to EKS version 1.22, deprecated nginx kubernetes.io/ingress.class and we need to upgrade to using ingressClassName then i have create PR to do this
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname]
)