Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add self-signed certificate init container #141

Merged
merged 20 commits into from
Nov 13, 2023
Merged

Conversation

eliobischof
Copy link
Member

@eliobischof eliobischof commented Nov 9, 2023

On top of the changes in #141 it adds an example and test for zitadel.selfSigned.enabled=true.
Also, it uses 127.0.0.1.sslip.io instead of localhost so ingress and TLS are easier testable.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

@eliobischof eliobischof self-assigned this Nov 10, 2023
@eliobischof eliobischof marked this pull request as ready for review November 10, 2023 15:16
@jessebot
Copy link
Contributor

Great to see this back in the works :) Thanks, @PurseChicken and @eliobischof !

@eliobischof eliobischof merged commit 4e17d23 into main Nov 13, 2023
@eliobischof eliobischof deleted the self-signed-review branch November 13, 2023 10:44
kleberbaum pushed a commit to fhkit/zitadel-charts that referenced this pull request May 24, 2024
* Add self signed init container enabled with selfSignedCert in values.

* reorder comment

* zitadel#133

* zitadel#136

* minor improvements

* use sslip

* fix: probes with enabled tls

* bump zitadel version

* use sslip

* use sslip

* test selfSigned.enabled

* bump chart testing action

* only probe on http

* increase timeout

---------

Co-authored-by: PurseChicken <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants