feat: set probe scheme to HTTPS when TLS is enabled #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliobischof
requested changes
Nov 14, 2023
Do want a patch bump to 7.2.1? And yes, if we implement this, and enable the probes in the self-signed example, the probes will succeed. |
eliobischof
requested changes
Nov 14, 2023
eliobischof
approved these changes
Nov 15, 2023
eliobischof
changed the title
eliobischof
changed the title
kleberbaum
pushed a commit
to fhkit/zitadel-charts
that referenced
this pull request
May 24, 2024
* Change scheme to HTTPS on probes when TLS is enabled. * Fix issue with potential NIL pointer if TLS is undefined. * bump minor version of chart and update to latest appVersion * Remove disabling probes from self-signed example * Use deepCheck helper for TLS.Enabled * Add newline to chart.yaml so linting succeeds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #143
Definition of Ready
This PR sets the liveliness, readiness and startup probe schemes to HTTPS if TLS is enabled in configmapConfig.
Without setting scheme: HTTPS it defaults to HTTP which causes the probes to fail and the pod(s) never report as healthy.