Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use .Values.image.tag for common labels #148

Merged
merged 1 commit into from
Dec 18, 2023
Merged

fix: Use .Values.image.tag for common labels #148

merged 1 commit into from
Dec 18, 2023

Conversation

lusu007
Copy link
Contributor

@lusu007 lusu007 commented Dec 8, 2023

The Chart now uses .Values.image.tag for the Kubernetes label app.kubernetes.io/version. If .Values.image.tag is not set it defaults to .Chart.AppVersion.

Fixes #139

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

@lusu007
fix: Use .Values.image.tag for common labels
d121a01 
The Chart now uses `.Values.image.tag` for the Kubernetes label `app.kubernetes.io/version`. If `.Values.image.tag` is not set it defaults to `.Chart.AppVersion`.
@lusu007 lusu007 force-pushed the fix/image-version-label branch from a8a0978 to d121a01 Compare December 8, 2023 11:53
@hifabienne hifabienne added the os-contribution This is a contribution from our open-source community label Dec 11, 2023
eliobischof
eliobischof approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@eliobischof eliobischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @lusu007 🙏

@eliobischof eliobischof merged commit 55b1146 into zitadel:main Dec 18, 2023
8 checks passed
@lusu007 lusu007 deleted the fix/image-version-label branch December 18, 2023 10:07
kleberbaum pushed a commit to fhkit/zitadel-charts that referenced this pull request May 24, 2024
@lusu007
fix: Use .Values.image.tag for common labels (zitadel#148)
a53fbc4 
The Chart now uses `.Values.image.tag` for the Kubernetes label `app.kubernetes.io/version`. If `.Values.image.tag` is not set it defaults to `.Chart.AppVersion`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliobischof eliobischof eliobischof approved these changes

Assignees
No one assigned
Labels
os-contribution This is a contribution from our open-source community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

selectorLabel "app.kubernetes.io/version" disregards .Values.image.tag override
3 participants
@lusu007 @eliobischof @hifabienne