Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update appVersion to v2.54.2 #210

Closed
wants to merge 4 commits into from
Closed

Conversation

kleberbaum
Copy link
Contributor

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

What is the current behavior?
The previously implemented workflow functionality from PR zitadel/zitadel#4544, which automatically triggered a webhook post-ZITADEL release, has been removed. Consequently, the bump workflow (introduced in #43 and discussed in Issue #105) is no longer dispatched, as it depends on this mechanism. This issue is also tracked in the Product Management Backlog under item 30889015.

What is the new behavior?
This PR updates the ZITADEL version to v2.54.1 manually.

What could be a permanent solution? To resolve Issue #105 it may be necessary to reimplement the changes from PR zitadel/zitadel#4544 in Current ZITADEL Release Workflow.

      - uses: tibdex/github-app-token@v1
        id: generate-token
        with:
          app_id: ${{ secrets.APP_ID }}
          private_key: ${{ secrets.APP_PRIVATE_KEY }}
      - name: Bump Chart Version
        uses: peter-evans/repository-dispatch@v2
        if: steps.semantic.outputs.new_release_published == 'true' && github.ref == 'refs/heads/main'
        with:
          token: ${{ steps.generate-token.outputs.token }}
          repository: zitadel/zitadel-charts
          event-type: zitadel-released
          client-payload: '{"semanticoutputs": "${{ steps.semantic.outputs }}"}'

However, the current bump workflow does not appear to be functional, as indicated by Bump Version.

image

_Originally posted by @kleberbaum in #198

Your feedback and suggestions would be greatly appreciated.

@hifabienne hifabienne added the os-contribution This is a contribution from our open-source community label Jun 5, 2024
@hifabienne hifabienne requested a review from eliobischof June 10, 2024 09:26
charts/zitadel/Chart.yaml Outdated Show resolved Hide resolved
@eliobischof eliobischof changed the title feat: update appVersion to v2.54.1 feat: update appVersion to v2.54.2 Jun 13, 2024
@panapol-p
Copy link
Contributor

hi, @kleberbaum @eliobischof I think we should update the CockroachDB chart version in the example and add more information about how to migrate to this chart.

FYI: Zitadel >= v2.53.0 cannot run on CockroachDB chart v11.2.1 (v23.1.1) It requires an upgrade to at least CockroachDB v23.2
Reference: Zitadel Documentation

As an example, for CockroachDB, we currently use chart v11.2.1 (CockroachDB v23.1.11). It would be better to upgrade to the latest version, helm chart v13.0.0 (CockroachDB v24.1.0). However, the database cannot be upgraded directly. You need to first upgrade from chart v11.2.1 (v23.1.1) to chart v12.0.5 (v23.2.5) and then to v13.0.0 (v24.1.0)

helm install db cockroachdb/cockroachdb --version 11.2.1 --values https://raw.githubusercontent.com/zitadel/zitadel-charts/main/examples/4-cockroach-secure/cockroach-values.yaml

@kleberbaum
Copy link
Contributor Author

hi, @kleberbaum @eliobischof I think we should update the CockroachDB chart version in the example and add more information about how to migrate to this chart.

Originally posted by @panapol-p in #210 (comment)

I've updated the CockroachDB Chart version to v13.0.1, but the checks are still failing.

I think we should upgrade the ZITADEL chart version to 8.0.0 as this will be a breaking change. A migration guide is also necessary.

@Mohit21GoJs
Copy link

Hi @kleberbaum We would like to use the version 2.54.2 or 2.55.0 in our apps, is there any timeline or examples to use it in our self hosted k8s environment?

@panapol-p
Copy link
Contributor

Hi, @Mohit21GoJs

To manually upgrade Zitadel to a new version:

  1. Backup Your Database: Ensure you have a backup of your database before starting the upgrade process.

  2. Upgrade CockroachDB:
    If you are using CockroachDB version <= v23.1.1, you must upgrade the database first. Run the following command:

    helm upgrade db cockroachdb/cockroachdb --version 12.0.5 --reuse-values
    

    Note: You can check the database upgrade progress by using this command:

    kubectl get pods \
    -o jsonpath='{range .items[*]}{.metadata.name}{"\t"}{.spec.containers[0].image}{"\n"}'
    
  3. Update Zitadel Configuration:
    Add the image tag in your Zitadel configuration (zitadel-values.yaml):

    image:
      tag: v2.54.3
    
  4. Upgrade Zitadel:
    Run the following command to upgrade Zitadel:

    helm upgrade my-zitadel zitadel/zitadel --values zitadel-values.yaml
    

If you use namespaces for your database and Zitadel, remember to include the --namespace flag for each command.

@panapol-p
Copy link
Contributor

@kleberbaum could you pls update this branch for new error handling

@eliobischof
Copy link
Member

@kleberbaum I am not allowed to commit to this PR, so I created a new one #219 and hope you have no hard feelings 🥲

I close this, for now. I see you should already have a ZITADEL shirt 👍 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os-contribution This is a contribution from our open-source community
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants