Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: squash #241

Merged
merged 4 commits into from
Aug 28, 2024
Merged

chore: squash #241

merged 4 commits into from
Aug 28, 2024

Conversation

eliobischof
Copy link
Member

@eliobischof eliobischof commented Aug 27, 2024 •
edited
Loading

Fixes https://github.com/zitadel/zitadel-charts/actions/runs/10584821199/job/29329962732

Completes #239

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

@eliobischof eliobischof changed the title Squash chore: squash Aug 27, 2024
@eliobischof eliobischof requested a review from stebenz August 27, 2024 19:57
@eliobischof eliobischof self-assigned this Aug 27, 2024
@eliobischof eliobischof enabled auto-merge (squash) August 27, 2024 20:09
@eliobischof eliobischof merged commit 216917d into main Aug 28, 2024
9 checks passed
@eliobischof eliobischof deleted the squash branch August 28, 2024 07:47
@eliobischof eliobischof mentioned this pull request Aug 28, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stebenz stebenz stebenz approved these changes

Assignees

@eliobischof eliobischof

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliobischof @stebenz