Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use go 1.23 #274

Merged
merged 1 commit into from
Nov 21, 2024
Merged

test: use go 1.23 #274

merged 1 commit into from
Nov 21, 2024

Conversation

eliobischof
Copy link
Member

Uses go v1.23 to run the testsuite.

Even though this code is not meant to be imported and therefore this change is IMO not necessary according to zitadel/zitadel#8906 because it already uses a supported go version, it can't hurt to upgrade it anyway.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

@eliobischof eliobischof self-assigned this Nov 21, 2024
@eliobischof
Copy link
Member Author

@muhlemmer did I misunderstand the issue or is it fine like this?

@eliobischof eliobischof mentioned this pull request Nov 21, 2024
9 tasks
@muhlemmer
Copy link
Contributor

Looks good to me!

@muhlemmer muhlemmer merged commit 1cb41ea into main Nov 21, 2024
10 checks passed
@muhlemmer muhlemmer deleted the go1.23 branch November 21, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants