Move hash-to-curve tests to tests/
for compilation performance
#15
Annotations
30 errors and 2 warnings
Clippy (beta)
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L710
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:710:5
|
710 | / assert_eq!(
711 | | bool::from(
712 | | Fp2 {
713 | | c0: P_M1_OVER2,
... |
718 | | true
719 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L700
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:700:5
|
700 | / assert_eq!(
701 | | bool::from(
702 | | Fp2 {
703 | | c0: p_p1_over2,
... |
708 | | false
709 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L690
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:690:5
|
690 | / assert_eq!(
691 | | bool::from(
692 | | Fp2 {
693 | | c0: -Fp::one(),
... |
698 | | false
699 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L680
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:680:5
|
680 | / assert_eq!(
681 | | bool::from(
682 | | Fp2 {
683 | | c0: -Fp::one(),
... |
688 | | false
689 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L670
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:670:5
|
670 | / assert_eq!(
671 | | bool::from(
672 | | Fp2 {
673 | | c0: -Fp::one(),
... |
678 | | false
679 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L659
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:659:5
|
659 | / assert_eq!(
660 | | bool::from(
661 | | Fp2 {
662 | | c0: p_p1_over2,
... |
667 | | false
668 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L649
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:649:5
|
649 | / assert_eq!(
650 | | bool::from(
651 | | Fp2 {
652 | | c0: P_M1_OVER2,
... |
657 | | true
658 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L639
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:639:5
|
639 | / assert_eq!(
640 | | bool::from(
641 | | Fp2 {
642 | | c0: Fp::zero(),
... |
647 | | false
648 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L629
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:629:5
|
629 | / assert_eq!(
630 | | bool::from(
631 | | Fp2 {
632 | | c0: p_p1_over2,
... |
637 | | false
638 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L619
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:619:5
|
619 | / assert_eq!(
620 | | bool::from(
621 | | Fp2 {
622 | | c0: P_M1_OVER2,
... |
627 | | true
628 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L608
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:608:5
|
608 | / assert_eq!(
609 | | bool::from(
610 | | Fp2 {
611 | | c0: Fp::one(),
... |
616 | | true
617 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L598
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:598:5
|
598 | / assert_eq!(
599 | | bool::from(
600 | | Fp2 {
601 | | c0: Fp::zero(),
... |
606 | | false
607 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L588
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:588:5
|
588 | / assert_eq!(
589 | | bool::from(
590 | | Fp2 {
591 | | c0: p_p1_over2,
... |
596 | | false
597 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L578
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:578:5
|
578 | / assert_eq!(
579 | | bool::from(
580 | | Fp2 {
581 | | c0: p_p1_over2,
... |
586 | | false
587 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L566
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:566:5
|
566 | / assert_eq!(
567 | | bool::from(
568 | | Fp2 {
569 | | c0: Fp::one(),
... |
574 | | true
575 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L556
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:556:5
|
556 | / assert_eq!(
557 | | bool::from(
558 | | Fp2 {
559 | | c0: Fp::zero(),
... |
564 | | true
565 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L546
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:546:5
|
546 | / assert_eq!(
547 | | bool::from(
548 | | Fp2 {
549 | | c0: P_M1_OVER2,
... |
554 | | true
555 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L536
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:536:5
|
536 | / assert_eq!(
537 | | bool::from(
538 | | Fp2 {
539 | | c0: P_M1_OVER2,
... |
544 | | true
545 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L535
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:535:5
|
535 | assert_eq!(bool::from(Fp2::one().sgn0()), true);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L534
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:534:5
|
534 | assert_eq!(bool::from(Fp2::zero().sgn0()), false);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g1.rs#L792
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g1.rs:792:5
|
792 | assert_eq!(bool::from(p_p1_over2.sgn0()), false);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g1.rs#L789
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g1.rs:789:5
|
789 | assert_eq!(bool::from(P_M1_OVER2.sgn0()), true);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g1.rs#L788
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g1.rs:788:5
|
788 | assert_eq!(bool::from((-Fp::zero()).sgn0()), false);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g1.rs#L787
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g1.rs:787:5
|
787 | assert_eq!(bool::from((-Fp::one()).sgn0()), false);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g1.rs#L786
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g1.rs:786:5
|
786 | assert_eq!(bool::from(Fp::one().sgn0()), true);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g1.rs#L785
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g1.rs:785:5
|
785 | assert_eq!(bool::from(Fp::zero().sgn0()), false);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assert!(..)`
|
= note: `-D clippy::bool-assert-comparison` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
5 bindings with single-character names in scope:
benches/groups.rs#L9
error: 5 bindings with single-character names in scope
--> benches/groups.rs:9:24
|
9 | fn criterion_benchmark(c: &mut Criterion) {
| ^
...
131 | let a = G2Projective::generator();
| ^
132 | let a_affine = G2Affine::generator();
133 | let s = Scalar::from_raw([1, 2, 3, 4]);
| ^
...
136 | let v = vec![G2Projective::generator(); N];
| ^
137 | let mut q = vec![G2Affine::identity(); N];
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
|
5 bindings with single-character names in scope:
benches/groups.rs#L9
error: 5 bindings with single-character names in scope
--> benches/groups.rs:9:24
|
9 | fn criterion_benchmark(c: &mut Criterion) {
| ^
...
62 | let a = G1Projective::generator();
| ^
63 | let a_affine = G1Affine::generator();
64 | let s = Scalar::from_raw([1, 2, 3, 4]);
| ^
...
67 | let v = vec![G1Projective::generator(); N];
| ^
68 | let mut q = vec![G1Affine::identity(); N];
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
|
5 bindings with single-character names in scope:
benches/groups.rs#L9
error: 5 bindings with single-character names in scope
--> benches/groups.rs:9:24
|
9 | fn criterion_benchmark(c: &mut Criterion) {
| ^
...
62 | let a = G1Projective::generator();
| ^
63 | let a_affine = G1Affine::generator();
64 | let s = Scalar::from_raw([1, 2, 3, 4]);
| ^
...
67 | let v = vec![G1Projective::generator(); N];
| ^
68 | let mut q = vec![G1Affine::identity(); N];
| ^
|
= note: `-D clippy::many-single-char-names` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
|
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Clippy (beta)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|