Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZipStore zarr storage backend. #79

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Add ZipStore zarr storage backend. #79

merged 1 commit into from
Nov 7, 2024

Conversation

zoj613
Copy link
Owner

@zoj613 zoj613 commented Nov 6, 2024

This commit adds a ZipStore storage backend as described in the specification zarr-developers/zarr-specs#311 . Note that the implementation loads the entire zip archive into memory so care must be taken to ensure the zip archive is not too big to fit into the machine's memory. To use a ZipStore impelementation that does not load the archive into memory see examples/zipstore.ml.

@zoj613 zoj613 added enhancement New feature or request storage related to storage labels Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 93.18182% with 6 lines in your changes missing coverage. Please review.

Project coverage is 98.02%. Comparing base (4ecee33) to head (b953e15).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
zarr/src/storage/zip.ml 93.18% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   98.24%   98.02%   -0.22%     
==========================================
  Files          18       19       +1     
  Lines        1424     1471      +47     
==========================================
+ Hits         1399     1442      +43     
- Misses         25       29       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoj613 zoj613 force-pushed the zipstore branch 5 times, most recently from 76dd687 to 8f3ad93 Compare November 6, 2024 15:33
This commit adds a ZipStore storage backend as described in the
specification zarr-developers/zarr-specs#311 .
Note that the implementation loads the entire zip archive into memory so
care must be taken to ensure the zip archive is not too big to fit into
the machine's memory. To use a ZipStore impelementation that does not
load the archive into memory see `examples/zipstore.ml`.
@zoj613 zoj613 merged commit 940605c into main Nov 7, 2024
2 of 4 checks passed
@zoj613 zoj613 deleted the zipstore branch November 7, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request storage related to storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant