Make requestNotifications options optional

zoontek · Jan 13, 2025 · 1e08069 · 1e08069
1 parent c513c50
commit 1e08069
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -755,7 +755,7 @@ The `rationale` is only available and used on Android. It can be a native alert
 
 ```ts
 function requestNotifications(
-  options: NotificationOption[], // only used by iOS
+  options?: NotificationOption[], // only used by iOS
   rationale?: Rationale,
 ): Promise<NotificationsResponse>;
 ```

diff --git a/example/ios/Podfile.lock b/example/ios/Podfile.lock
@@ -1575,7 +1575,7 @@ PODS:
     - React-logger (= 0.76.2)
     - React-perflogger (= 0.76.2)
     - React-utils (= 0.76.2)
-  - RNPermissions (5.2.2):
+  - RNPermissions (5.2.3):
     - DoubleConversion
     - glog
     - hermes-engine
@@ -1893,7 +1893,7 @@ SPEC CHECKSUMS:
   React-utils: c8c0c746031419a29cfd8c72a394fdeac0684a84
   ReactCodegen: a64e8f3a8bba0ecf88fce06c2874e021d55148f3
   ReactCommon: 7b9403030ff3430ccffed63cd25c8aeab2a3ea7e
-  RNPermissions: 58daf8003d82766ca706ec9b19b7e54d74b5e4f4
+  RNPermissions: dd5cd0b304f83156d217b43564bb348d91b10d6a
   RNVectorIcons: a24016b773380b1aa37fca501ec6b94a951890a0
   SocketRocket: d4aabe649be1e368d1318fdf28a022d714d65748
   Yoga: 96872ee462cfc43866ad013c8160d4ff6b85709b

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-native-permissions",
-  "version": "5.2.2",
+  "version": "5.2.3",
   "license": "MIT",
   "description": "An unified permissions API for React Native on iOS, Android and Windows",
   "author": "Mathieu Acthernoene <[email protected]>",

diff --git a/src/contract.ts b/src/contract.ts
@@ -24,7 +24,7 @@ export type Contract = {
     permissions: P,
   ): Promise<Record<P[number], PermissionStatus>>;
   requestNotifications(
-    options: NotificationOption[],
+    options?: NotificationOption[],
     rationale?: Rationale,
   ): Promise<NotificationsResponse>;
 };
diff --git a/src/methods.android.ts b/src/methods.android.ts
@@ -70,7 +70,7 @@ const checkNotifications: Contract['checkNotifications'] = async () => {
   }
 };
 
-const requestNotifications: Contract['requestNotifications'] = async (options, rationale) => {
+const requestNotifications: Contract['requestNotifications'] = async (options = [], rationale) => {
   if (USES_LEGACY_NOTIFICATIONS) {
     const response = (await NativeModule.requestNotifications(options)) as NotificationsResponse;
     return response;

diff --git a/src/methods.ios.ts b/src/methods.ios.ts
@@ -37,7 +37,9 @@ const checkNotifications: Contract['checkNotifications'] = async () => {
   return response;
 };
 
-const requestNotifications: Contract['requestNotifications'] = async (options) => {
+const requestNotifications: Contract['requestNotifications'] = async (
+  options = ['alert', 'badge', 'sound'],
+) => {
   const response = (await NativeModule.requestNotifications(options)) as NotificationsResponse;
   return response;
 };