Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.7, add Python 3.13, use latest meta/config templates #125

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

dataflake
Copy link
Member

No description provided.

@dataflake dataflake requested a review from icemac September 17, 2024 12:58
@dataflake dataflake self-assigned this Sep 17, 2024
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me have a look, why coverage has dropped below the threshold.

docs/conf.py Outdated Show resolved Hide resolved
Co-authored-by: Michael Howitz <[email protected]>
@icemac
Copy link
Member

icemac commented Sep 18, 2024

It seems to be because of _compat.py where not all code seems to be needed: https://coveralls.io/builds/69841069/source?filename=src%2Ftransaction%2F_compat.py
Maybe we can even get rid of the whole module.

@dataflake
Copy link
Member Author

It seems to be because of _compat.py where not all code seems to be needed: https://coveralls.io/builds/69841069/source?filename=src%2Ftransaction%2F_compat.py Maybe we can even get rid of the whole module.

That's now done. But the fact that coveralls complains about -0.01% is extremely annoying. Can you change that so it never complains unless there's at least a 0.5% change?

@icemac
Copy link
Member

icemac commented Sep 18, 2024

I changed the coveralls config and re-ran the tests.

BTW changing coveralls config is not depending on me. Using GitHub sign-in each contributor of ZF can change the settings there.

@icemac
Copy link
Member

icemac commented Sep 18, 2024

I changed the coveralls config and re-ran the tests.

But the required coverage was 99.7 thus a bit too high, so I changed also this requirement.

@dataflake
Copy link
Member Author

Thank you!

@dataflake dataflake merged commit 24900b9 into master Sep 18, 2024
16 checks passed
@dataflake dataflake deleted the config-with-pure-python-template-a8ae60f1 branch September 18, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants