Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show library datasets under correct library name #213

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AndrewTwydell
Copy link
Contributor

What It Does
Resolves #212 .

This changes the LibraryTreeItems to use a default filter of their Library name so only the Library datasets in that Library show up in that tree. Then it appends the active filter of the library to that filter to search the DSName attribute.

How to Test

Have multiple Library resources with different datasets in. Expand each library. Before this update, they would show the same datasets - now they should show correct datasets.

Review Checklist
I certify that I have:

Additional Comments

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 28.25%. Comparing base (61f57a8) to head (4d38d6b).

Files with missing lines Patch % Lines
...es/vsce/src/trees/treeItems/CICSLibraryTreeItem.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #213   +/-   ##
=======================================
  Coverage   28.25%   28.25%           
=======================================
  Files         146      146           
  Lines        4987     4986    -1     
  Branches      869      804   -65     
=======================================
  Hits         1409     1409           
+ Misses       3578     3577    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review/QA
Development

Successfully merging this pull request may close these issues.

Library Tree shows all library datasets in all library tree items
2 participants