Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC for Mobile App #241

Open
wants to merge 4 commits into
base: v1.x/staging
Choose a base branch
from

Conversation

lchudinov
Copy link
Contributor

@lchudinov lchudinov commented Jun 11, 2020

@lchudinov lchudinov marked this pull request as draft June 11, 2020 05:26
Copy link
Member

@1000TurquoisePogs 1000TurquoisePogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SimpleWindowManager in virtual-desktop could have an overlay that exists above the login overlay, which is only shown when the browser user agent is a mobile one, or some other global tells you that it is mobile. That overlay can prompt the user to give the location of the app server. That information could be stored in the app's data for next use.

static dispatcher: Dispatcher = new Dispatcher(cordovaLogger);
static logger: Logger = logger;
static registry: ZLUX.Registry = new Registry();
static notificationManager: ZoweNotificationManager = new ZoweNotificationManager();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could do android/ios notifications, if it knew it was mobile.

export class CordovaResources {
static pluginManager = PluginManager
static uriBroker: ZLUX.UriBroker = new MvdUri();
static dispatcher: Dispatcher = new Dispatcher(cordovaLogger);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder if dispatcher could use android "intents" to open another app on your phone which is also a zowe app.


export class CordovaResources {
static pluginManager = PluginManager
static uriBroker: ZLUX.UriBroker = new MvdUri();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uribroker includes access to the config service, but on mobile, maybe there will be a config service enhancement to allow the app to choose if data is stored locally or remotely.

@lchudinov lchudinov force-pushed the feature/poc-for-mobile-app branch from fff49aa to 15f5dc9 Compare June 17, 2020 12:40
@lchudinov lchudinov marked this pull request as ready for review June 22, 2020 09:46
Leonty Chudinov added 3 commits July 20, 2020 07:52
Signed-off-by: Leonty Chudinov <[email protected]>
Signed-off-by: Leonty Chudinov <[email protected]>
Signed-off-by: Leonty Chudinov <[email protected]>
@lchudinov lchudinov force-pushed the feature/poc-for-mobile-app branch from 15f5dc9 to 0e63945 Compare July 20, 2020 03:01
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (1.8.0_242) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

Copy link
Member

@DivergentEuropeans DivergentEuropeans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a test approve (remove later)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

3 participants