Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add react 19 in peerDependencies #381

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Add react 19 in peerDependencies #381

merged 1 commit into from
Dec 11, 2024

Conversation

Yohannfra
Copy link
Contributor

Fix #380

zpao
zpao reviewed Nov 11, 2024
View reviewed changes
Copy link
Owner

@zpao zpao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was waiting for React 19 to actually ship. I haven't actually tested with the prereleases and this range doesn't pick them up anyway.

So I'll hold off for now.

@MMontalto
Copy link

I was waiting for React 19 to actually ship. I haven't actually tested with the prereleases and this range doesn't pick them up anyway.

So I'll hold off for now.

React 19 is out as stable 4 days ago

@zpao
Copy link
Owner

zpao commented Dec 11, 2024

Ok, let's do it. Thanks! And thanks for poking this after the release @MMontalto

@zpao zpao added this to the 4.2.0 milestone Dec 11, 2024
@zpao zpao merged commit 858d283 into zpao:trunk Dec 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zpao zpao zpao left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

Support React 19
3 participants
@Yohannfra @MMontalto @zpao