Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lorca.New returning EOF #121

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Fix lorca.New returning EOF #121

wants to merge 3 commits into from

Conversation

jujhar16
Copy link

@jujhar16 jujhar16 commented Aug 26, 2020 •
edited
Loading

Fixes #119 by not relying on stderr. There is still the issue of Done() relying on chrome.cmd.Wait(). And sometimes the browser has not started hosting the remote debugging version, which causes the json/version request to fail.

@jujhar16 jujhar16 marked this pull request as draft August 26, 2020 07:36
@justinmichaelvieira justinmichaelvieira mentioned this pull request Sep 6, 2023
Open
@DavidArthurCole DavidArthurCole mentioned this pull request Jul 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lorca.New returns EOF because of lorca.readUntilMatch
1 participant
@jujhar16