Skip to content

Commit

Permalink
Address review feedback
Browse files Browse the repository at this point in the history
Signed-off-by: Viktor Söderqvist <[email protected]>
  • Loading branch information
zuiderkwast committed May 2, 2024
1 parent c58a9ac commit 47ed092
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/commands/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ following keys. To be safe, assume all of them are optional.
negative number means "at least", e.g. -3 means at least 3.
* `"container"`: Only present for subcommands. See below.
* `"history"`: An array of changes, each change represented by a 2-element array
on the form `[VERSION, DESCRIPTION]`.
on the form `[VERSION, DESCRIPTION]`. Omit if empty. Don't add an empty array.
* `"function"`: The name of the C function in Valkey's source code implementing
the command. (Don't use it for anything else.)
* `"command_flags"`: An array of flags represented as strings. Command flags:
Expand Down Expand Up @@ -153,6 +153,9 @@ documentation was written):
* Command flag BLOCKING implies ACL category BLOCKING.
* Not ACL category FAST implies ACL category SLOW. "If it's not fast, it's slow."

There's an issue about explicitly listing all categories, removing this
discrepancy: https://github.com/valkey-io/valkey/issues/417

Key specs
---------

Expand Down

0 comments on commit 47ed092

Please sign in to comment.