Skip to content

Commit

Permalink
Skip CLI tests with reply schema validation (valkey-io#1545)
Browse files Browse the repository at this point in the history
The commands used in valkey-cli tests are not important the reply schema
validation. Skip them to avoid the problem if tests hanging. This has
failed lately in the daily job:

```
[TIMEOUT]: clients state report follows.
sock55fedcc19be0 => (IN PROGRESS) valkey-cli pubsub mode with single standard channel subscription
Killing still running Valkey server 33357
```

These test cases use a special valkey-cli command `:get pubsub` command,
which is an internal command to valkey-cli rather than a Valkey server
command. This command hangs when compiled with with logreqres enabled.
Easy solution is to skip the tests in this setup.

The test cases were introduced in valkey-io#1432.

Signed-off-by: Viktor Söderqvist <[email protected]>
  • Loading branch information
zuiderkwast authored Jan 12, 2025
1 parent 11cb8ee commit ad592f7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/integration/valkey-cli.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ if {$::singledb} {
set ::dbnum 9
}

start_server {tags {"cli"}} {
start_server {tags {"cli logreqres:skip"}} {
proc open_cli {{opts ""} {infile ""}} {
if { $opts == "" } {
set opts "-n $::dbnum"
Expand Down

0 comments on commit ad592f7

Please sign in to comment.