i18n: Update label to 'Messages with yourself' in DM header #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lakshya1goel
force-pushed
the
issue1319
branch
from
cfeace2 to
53dd04c
Compare
lakshya1goel
force-pushed
the
issue1319
branch
from
53dd04c to
fefccea
Compare
chrisbobbe
requested changes
Feb 6, 2025
There was a problem hiding this comment.
i18n: Update label to "Messages with yourself" in DM header
commit-message nit: choose a different prefix than i18n. This commit involves the i18n subsystem, because it's changing a UI string and we translate those—but it isn't a change in the i18n subsystem itself. How about msglist.
|
Also, updating the PR title to remove |
chrisbobbe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1319
Screenshot