Icon for "switch account" in main menu #1338
Open
+43
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has many changes unrelated to #1178; those need to be removed before we can review. |
|
The changes should only be to the following files right?:
|
|
Determining exactly which files should be changing is part of the work of resolving this issue (or any issue) 🙂. If you need help or have questions, the place to ask is in #mobile-dev-help on chat.zulip.org. In any event, the essential part is that you should reread your changes and understand why each change you're making needs to be there: |
|
Hey @gnprice can you check the pull request once? I hope I have made the necessary changes! if not ill work on it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The icon has been taken from figma as requested: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=6141-40422&t
fixes: #1178