Update vacuum and use Vacuum OWASP rules #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updating Vacuum to the latest version. It should be stable enough to start using in production again - but I will need to test this out in a followup PR. The new vacuum update brought native support for OWASP rules, which I removed from the
spectral-supplement. This should result in overall better performance. Unfortunately, there are still some blockers on Vacuum that prevent us from switching fully over to it, the supplement must stay for now.I also dabbled with custom JS function on Vacuum to integrate some Speakeasy linting rules - but its too unstable so I commented them out for now. Technically, Spectral can run these too but I don't want to spend too much time on this area right now