Skip to content
This repository has been archived by the owner on Sep 7, 2024. It is now read-only.

feat: add guide to iip-template.md #10

Merged
merged 3 commits into from
Nov 19, 2023
Merged

feat: add guide to iip-template.md #10

merged 3 commits into from
Nov 19, 2023

Conversation

eznix86
Copy link
Contributor

@eznix86 eznix86 commented Nov 15, 2023

iip-template.md Outdated Show resolved Hide resolved
iip-template.md Show resolved Hide resolved
@kehiy
Copy link
Member

kehiy commented Nov 15, 2023

@eznix86 we can just write the template in iip-template.md and keep guides in the contributing file. what do you think? (or just comment the guides)

because we need to people can just copy and paste this and start writing their iip.

Also, I think it will be good to add a motivation and specification part in the template.

have a look at these files, you can get some ideas:

https://github.com/pactus-project/PIPs/blob/main/pip-template.md //The explanations are commented

@eznix86
Copy link
Contributor Author

eznix86 commented Nov 15, 2023

@eznix86 we can just write the template in iip-template.md and keep guides in the contributing file. what do you think? (or just comment the guides)

because we need to people can just copy and paste this and start writing their iip.

Also, I think it will be good to add a motivation and specification part in the template.

have a look at these files, you can get some ideas:

https://github.com/pactus-project/PIPs/blob/main/pip-template.md //The explanations are commented

Yes, I will move things around so it match this description

@kehiy
Copy link
Member

kehiy commented Nov 15, 2023

Yes, I will move things around so they match this description

ok, address these 3 issues, and then we can merge them and start work on pip-00

@kehiy
Copy link
Member

kehiy commented Nov 16, 2023

@eznix86 this pr is in which state?

@eznix86
Copy link
Contributor Author

eznix86 commented Nov 19, 2023

@eznix86 this pr is in which state?

Pushing some changes to this PR

iip-template.md Outdated Show resolved Hide resolved
Copy link
Member

@kehiy kehiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eznix86 thanks, that's nice.

@kehiy kehiy merged commit 1846cd7 into zurvan-lab:main Nov 19, 2023
2 checks passed
@eznix86
Copy link
Contributor Author

eznix86 commented Nov 19, 2023

Tiny error while copy pasting 😂

@kehiy
Copy link
Member

kehiy commented Nov 19, 2023

no problem 😂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iip-template
2 participants