Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pre-deployed erc20 gas token #386

Merged
merged 14 commits into from
Nov 25, 2024

Conversation

leovct
Copy link
Member

@leovct leovct commented Nov 19, 2024

Description

Allow to use a pre-deployed ERC20 gas token.

Now we support three different configurations related to the gas token:

  1. Don't use a gas token (default behaviour)
args:
  gas_token_enabled: false
  1. Use a gas token but automatically deploy the contract on L1.
args:
  gas_token_enabled: true
  1. Use a gas token and use the provided contract address.
args:
  gas_token_enabled: true
  gas_token_address: "0xCONTRACT_ADDRESS"

Tests

The following tests should be added to the CI:

  • Use a gas token but automatically deploy the contract on L1.
  • Use a gas token and use the provided contract address.

🚨 Unfortunately, it broke all the cdk tests related to gas token... I fixed the tests on my fork and will push an upstream PR once this PR gets merged.

References (if applicable)

@leovct leovct marked this pull request as draft November 19, 2024 17:01
@leovct leovct force-pushed the feat/pre-deployed-erc20-gas-token branch from 7b74d8b to 05d8995 Compare November 21, 2024 12:52
@leovct leovct marked this pull request as ready for review November 21, 2024 14:32
@leovct leovct requested a review from a team November 21, 2024 14:32
input_parser.star Show resolved Hide resolved
templates/contract-deploy/run-contract-setup.sh Outdated Show resolved Hide resolved
@leovct leovct enabled auto-merge (squash) November 25, 2024 16:27
@leovct leovct merged commit 91147af into 0xPolygon:main Nov 25, 2024
23 checks passed
@leovct leovct deleted the feat/pre-deployed-erc20-gas-token branch November 25, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants