Rock Smash: Do not soft reset after catching a Pokémon #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Neka pointed out, the Rock Smash mode would just keep going after catching a Shiny/CCF Pokémon in Rock Smash mode -- which is an issue because these modes soft-reset after a while. This is not an issue if `save_after_catching` is enabled because then soft-resetting would just load the game state _after_ catching the Pokémon. So if that setting is NOT enabled (it's off by default), we switch to manual mode after catching something.
pekempy
approved these changes
Jan 20, 2025
40Cakes
pushed a commit
that referenced
this pull request
Jan 22, 2025
Rock Smash: Do not soft reset after catching a Pokémon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As Neka pointed out, the Rock Smash mode would just keep going after catching a Shiny/CCF Pokémon in Rock Smash mode -- which is an issue because these modes soft-reset after a while.
This is not an issue if
save_after_catchingis enabled because then soft-resetting would just load the game state after catching the Pokémon.So if that setting is NOT enabled (it's off by default), we switch to manual mode after catching something.
Checklist
--line-length 120argument