Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a hash to the user data scripts so terraform will see changes exist and replace them as needed #49

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

cbailey6079
Copy link

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you store the loaded template file contents into a local car so we're not loading it twice? Small thing, but I think it will make this read slightly better and require changes in less places in the future.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Comment on lines +2 to +3
web_user_data_content = sensitive(templatefile("${path.module}/templates/web_user_data.sh", local.web_interpolation_vars))
worker_user_data_content = sensitive(templatefile("${path.module}/templates/worker_user_data.sh", local.worker_interpolation_vars))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you happen to double check that using sensitive here translates to the value being obfuscated when used in the terraforming of the s3 object below?

Copy link
Author

@cbailey6079 cbailey6079 Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i did see that the values were obfuscated in the terraform or what i believe was this file. Obviously the file has all the keys in plain text in s3.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dumptruckman dumptruckman merged commit 2113729 into main Apr 26, 2024
1 check passed
@dumptruckman dumptruckman deleted the clayton/user-data-template-fix branch April 26, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants