Adding a hash to the user data scripts so terraform will see changes exist and replace them as needed #49
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,8 @@ | ||
| locals { | ||
| web_user_data_content = sensitive(templatefile("${path.module}/templates/web_user_data.sh", local.web_interpolation_vars)) | ||
| worker_user_data_content = sensitive(templatefile("${path.module}/templates/worker_user_data.sh", local.worker_interpolation_vars)) | ||
|
Comment on lines
+2
to
+3
There was a problem hiding this comment. Did you happen to double check that using sensitive here translates to the value being obfuscated when used in the terraforming of the s3 object below? There was a problem hiding this comment. i did see that the values were obfuscated in the terraform or what i believe was this file. Obviously the file has all the keys in plain text in s3. There was a problem hiding this comment. https://developer.hashicorp.com/terraform/language/functions/sensitive this shows the same use from hashicorp |
||
| } | ||
|
|
||
| resource "aws_s3_bucket" "user_data" { | ||
| bucket = var.user_data_bucket_name | ||
| } | ||
|
|
@@ -55,14 +60,17 @@ resource "aws_s3_object" "cw_agent_prometheus_init" { | |
| }) | ||
| } | ||
|
|
||
|
|
||
| resource "aws_s3_object" "web_user_data" { | ||
| bucket = aws_s3_bucket.user_data.id | ||
| key = "web_user_data.sh" | ||
| content = local.web_user_data_content | ||
| source_hash = md5(local.web_user_data_content) | ||
| } | ||
|
|
||
| resource "aws_s3_object" "worker_user_data" { | ||
| bucket = aws_s3_bucket.user_data.id | ||
| key = "worker_user_data.sh" | ||
| content = local.worker_user_data_content | ||
| source_hash = md5(local.worker_user_data_content) | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you store the loaded template file contents into a local car so we're not loading it twice? Small thing, but I think it will make this read slightly better and require changes in less places in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated