Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an async checkpointer to initialize JDI in tests #1170

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gobbleturk
Copy link
Collaborator

@gobbleturk gobbleturk commented Jan 16, 2025

Description

According to this logic we only initialize the jax distributed system for an async checkpointer, but it looks like sometime recently in orbax this is needed even for a sync checkpointer. We should modify this logic but it may break some single host or pathways use cases which don't need the distributed system. A short term fix is to use an async checkpointer so that the jax distributed system is broken, e.g. for the end_to_end tests b/389730949

Tests

Ran gemma step 2 locally

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@gobbleturk gobbleturk force-pushed the mattdavidow-async-fix branch from 19c2a51 to 1dcb404 Compare January 16, 2025 00:31
Copy link
Collaborator

@khatwanimohit khatwanimohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Matt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants